Template failed to apply defaults values when env doesn't exist.

[rollniak]

Hello,

I'm writing a hook that let ACMEd call PowerDNS via an API to do a dns-01 challenge.

I've made good progress in the making and now try to replace the hardcoded value by replacing them with environment variable.

When I set the environment variable, everything work fine. But if I comment them, the hook failed with the following error instead of fallback to the default values.

[2023-05-29T11:34:33Z DEBUG acmed::certificate] certificate "rollniak.eu_rsa2048": calling hook "pdns-01-api-create"
[2023-05-29T11:34:33Z WARN  acmed::certificate] certificate "rollniak.eu_rsa2048": unable to renew the certificate: pdns-01-api-create: template error: Encountered rendering error on line 1, column 10. Reason: Failed to find value 'PDNS_SERVER_ADDRESS' from path 'env.PDNS_SERVER_ADDRESS'. Available values at this level are 'CHARSET', 'HOME', 'LANG', 'LC_COLLATE', 'LOGNAME', 'MAIL', 'OLDPWD', 'PAGER', 'PATH', 'PDNS_API_KEY', 'PWD', 'SHELL', 'SHLVL', 'SSL_CERT_DIR', 'SSL_CERT_FILE', 'SUDO_COMMAND', 'SUDO_GID', 'SUDO_UID', 'SUDO_USER', 'TERM', 'TERM_PROGRAM', 'TERM_PROGRAM_VERSION', 'TMUX', 'TMUX_PANE', 'USER'

The hook need five env :

• env.PDNS_SERVER_ADDRESS (Optional, Default: localhost)
• env.PDNS_SERVER_PORT (Optional, Default: 8081)
• env.PDNS_SERVER_ID (Optional, Default: localhost)
• env.PDNS_ZONE_ID (Optional, Default: { identifier })
• env.PDNS_API_KEY (Requiered)

The hook :

[[hook]]
name = "pdns-01-api-create"
type = ["challenge-dns-01"]
cmd = "curl"
args = [
    "--fail-with-body",
    "-v",
    "-H", 'X-API-Key: { env.PDNS_API_KEY }',
    "-H", 'Content-Type: application/json',
    "-X", "PATCH",
    "-d", '\{"rrsets": [\{"name": "_acme-challenge.{ identifier }.", "type": "TXT", "ttl": 1, "changetype": "REPLACE", "records": [\{"content": "\"{ proof }\"", "disabled": false}]}]}',
    "{{ if env.PDNS_SERVER_ADDRESS }}{ env.PDNS_SERVER_ADDRESS }{{ else }}localhost{{ endif }}:{{ if env.PDNS_SERVER_PORT }}{ env.PDNS_SERVER_PORT }{{ else }}8081{{ endif }}/api/v1/servers/{{ if env.PDNS_SERVER_ID }}{ env.PDNS_SERVER_ID }{{ else }}localhost{{ endif }}/zones/{{ if env.PDNS_ZONE_ID }}{ env.PDNS_ZONE_ID }{{ else }}{ identifier }{{ endif}}.",
]
allow_failure = false

[[hook]]
name = "pdns-01-api-clean"
type = ["challenge-dns-01-clean"]
cmd = "curl"
args = [
    "--fail-with-body",
    "-v",
    "-H", 'X-API-Key: REDACTED',
    "-H", 'Content-Type: application/json',
    "-X", "PATCH",
    "-d", '\{"rrsets": [\{"name": "_acme-challenge.{ identifier }.", "type": "TXT", "changetype": "DELETE", "records": [\{"content": "\"{ proof }\"", "disabled": false}]}]}',
    "localhost:8081/api/v1/servers/localhost/zones/rollniak.eu.",
]
allow_failure = false

[[group]]
name = "pdns-01-api"
hooks = [
    "pdns-01-api-create",
    "pdns-01-api-clean",
]

The env file :

[global]
#env.PDNS_SERVER_ADDRESS = "localhost"
#env.PDNS_SERVER_PORT   = "8081"
#env.PDNS_SERVER_ID     = "localhost"
#env.PDNS_ZONE_ID       = "rollniak.eu"
env.PDNS_API_KEY        = "REDACTED"

The expected outcome is :
If one or all environment variable are set, then use them, else use default value.

I used the default_hooks.toml as an example.
I don't understand why it's not working with my hook where the same kind of if/else/endif conditions work with the HTTP-01 challenge.... Any idea ?

Rollniak.

[breard-r]

Hi,

Since the merge of PR #99 changed the template engine, does this bug still exists?