Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this lib is not working correctly with Typescript #234

Open
KseniaKapnik opened this issue Aug 3, 2018 · 1 comment
Open

this lib is not working correctly with Typescript #234

KseniaKapnik opened this issue Aug 3, 2018 · 1 comment

Comments

@KseniaKapnik
Copy link

There is no declaration file for this package.
Causes error in case of using with typescript import.
The types field is missed in package.json, it could be something like:

"types": "./lib/lawnchair.d.ts",

The lawnchair.d.ts file itself need only to declare Lawnchair

import 'lawnchair'

declare module 'lawnchair' {
  export default function Lawnchair(config: Object, callback: Function): void;
}
@MarkMYoung
Copy link
Collaborator

Thank you for this, @KseniaKapnik. I you would make a pull request with those changes, I would be happy to merge it. Otherwise, I'll have to make the pull request as time permits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants