Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused dependencies on Test2:: modules #8

Open
ppisar opened this issue Feb 3, 2022 · 0 comments
Open

Unused dependencies on Test2:: modules #8

ppisar opened this issue Feb 3, 2022 · 0 comments

Comments

@ppisar
Copy link

ppisar commented Feb 3, 2022

There is a regression in 1.160000 version:

Makefile.PL reads:

  "TEST_REQUIRES" => {
    "ExtUtils::MakeMaker" => 0,
    "File::Spec" => 0,
    "File::Temp" => 0,
    "Test2::Bundle::Extended" => 0,
    "Test2::Plugin::NoWarnings" => 0,
    "Test2::Tools::Explain" => 0,
    "Test::More" => 0
  },

But there is no use of File::Temp, Test2::Bundle::Extended, Test2::Plugin::NoWarnings, and Test2::Tools::Explain modules in the ./t directory. They are only tested for an available version by t/00-report-prereqs.t:

$ grep -Hnr Test2:: t
t/00-report-prereqs.dd:34: 'Test2::Bundle::Extended' => '0',
t/00-report-prereqs.dd:35: 'Test2::Plugin::NoWarnings' => '0',
t/00-report-prereqs.dd:36: 'Test2::Tools::Explain' => '0',
t/00-report-prereqs.dd:45: 'Test2::Bundle::Extended' => '0',
t/00-report-prereqs.dd:46: 'Test2::Plugin::NoWarnings' => '0',
t/00-report-prereqs.dd:47: 'Test2::Tools::Explain' => '0',

I recommend removing those dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant