From 662bb7560df1e5275164b17f7315e31c605d3c6a Mon Sep 17 00:00:00 2001 From: "Christopher J. Brody" Date: Thu, 2 Apr 2020 11:12:10 -0400 Subject: [PATCH 1/6] add `native` item with package ID to `package.json` in order to make the `android/build.gradle` artifact 100% generic i.e. rendered directly from the template, with zero module-specific customization --- templates/android.js | 4 ++-- templates/general.js | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/templates/android.js b/templates/android.js index ffea49d0..2eda81d5 100644 --- a/templates/android.js +++ b/templates/android.js @@ -1,6 +1,6 @@ module.exports = platform => [{ name: () => `${platform}/build.gradle`, - content: ({ packageIdentifier }) => `// ${platform}/build.gradle + content: () => `// ${platform}/build.gradle // based on: // @@ -84,7 +84,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = "${packageIdentifier}" + group = packageJson.native.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/templates/general.js b/templates/general.js index 018b42b0..33b7e356 100644 --- a/templates/general.js +++ b/templates/general.js @@ -21,7 +21,7 @@ ${name}; `, }, { name: () => 'package.json', - content: ({ moduleName, platforms, githubAccount, authorName, authorEmail, license }) => { + content: ({ moduleName, packageIdentifier, platforms, githubAccount, authorName, authorEmail, license }) => { const peerDependencies = `{ "react": "^16.8.1", @@ -58,6 +58,9 @@ ${name}; "license": "${license}", "licenseFilename": "LICENSE", "readmeFilename": "README.md", + "native": { + "packageIdentifier": "${packageIdentifier}" + }, "peerDependencies": ${peerDependencies}, "devDependencies": ${devDependencies} } From 4b320e9e68104fe1ba29e5c3c54167a8d6879cdb Mon Sep 17 00:00:00 2001 From: "Christopher J. Brody" Date: Thu, 2 Apr 2020 11:13:15 -0400 Subject: [PATCH 2/6] make it `android` item with the `packageIdentifier` field in `package.json` --- templates/android.js | 2 +- templates/general.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/android.js b/templates/android.js index 2eda81d5..eedf4387 100644 --- a/templates/android.js +++ b/templates/android.js @@ -84,7 +84,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.native.packageIdentifier + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/templates/general.js b/templates/general.js index 33b7e356..02ad7538 100644 --- a/templates/general.js +++ b/templates/general.js @@ -58,7 +58,7 @@ ${name}; "license": "${license}", "licenseFilename": "LICENSE", "readmeFilename": "README.md", - "native": { + "android": { "packageIdentifier": "${packageIdentifier}" }, "peerDependencies": ${peerDependencies}, From 16bfdcc9464b7aded2285a8aff10ed21e8dc5ef2 Mon Sep 17 00:00:00 2001 From: "Christopher J. Brody" Date: Thu, 2 Apr 2020 11:07:28 -0400 Subject: [PATCH 3/6] update test snapshots --- .../view/__snapshots__/cli-create-with-view.test.js.snap | 5 ++++- .../__snapshots__/cli-create-with-defaults.test.js.snap | 5 ++++- .../__snapshots__/create-view-with-defaults.test.js.snap | 5 ++++- .../create-view-with-example-with-defaults.test.js.snap | 5 ++++- .../create-view-with-example-with-options.test.js.snap | 5 ++++- .../lib-view-android-config-options.test.js.snap | 5 ++++- .../create-view-with-options-for-ios.test.js.snap | 3 +++ .../__snapshots__/create-with-defaults.test.js.snap | 5 ++++- .../__snapshots__/bogus-platforms-name.test.js.snap | 3 +++ .../__snapshots__/bogus-platforms-empty-array.test.js.snap | 3 +++ .../__snapshots__/bogus-platforms-empty-string.test.js.snap | 3 +++ .../create-with-example-for-android-only.test.js.snap | 5 ++++- .../create-with-example-with-defaults.test.js.snap | 5 ++++- .../recover-from-missing-package-scripts.test.js.snap | 5 ++++- .../create-with-example-with-null-prefix.test.js.snap | 5 ++++- .../create-with-example-with-options.test.js.snap | 5 ++++- .../create-with-name-in-camel-case.test.js.snap | 5 ++++- .../create-with-options-for-android.test.js.snap | 5 ++++- .../__snapshots__/create-with-options-for-ios.test.js.snap | 3 +++ .../__snapshots__/platforms-array.test.js.snap | 5 ++++- .../__snapshots__/platforms-comma-separated.test.js.snap | 5 ++++- .../create-with-custom-module-prefix.test.js.snap | 5 ++++- .../__snapshots__/create-with-module-name.test.js.snap | 5 ++++- .../cli-command-with-bogus-platforms-name.test.js.snap | 3 +++ .../cli-command-with-empty-platforms-string.test.js.snap | 3 +++ .../__snapshots__/cli-command-func-with-options.test.js.snap | 5 ++++- .../cli-program-with-defaults-for-android.test.js.snap | 5 ++++- .../create-with-example-with-defaults.test.js.snap | 5 ++++- .../__snapshots__/with-yarn-error-logging.test.js.snap | 5 ++++- .../create-with-example-with-options.test.js.snap | 5 ++++- .../create-with-example-with-options.test.js.snap | 5 ++++- 31 files changed, 117 insertions(+), 24 deletions(-) diff --git a/tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap b/tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap index e03431bc..1c452dfa 100644 --- a/tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap +++ b/tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap @@ -182,7 +182,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl @@ -667,6 +667,9 @@ RCT_EXPORT_MODULE() \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap b/tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap index bb6ce78a..b76e6a28 100644 --- a/tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap +++ b/tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap @@ -182,7 +182,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl @@ -663,6 +663,9 @@ RCT_EXPORT_METHOD(sampleMethod:(NSString *)stringArgument numberParameter:(nonnu \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap b/tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap index 5013a131..3a0e5465 100644 --- a/tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap +++ b/tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap @@ -86,6 +86,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -257,7 +260,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap b/tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap index 9bc4b11d..2c0ccc82 100644 --- a/tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap +++ b/tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap @@ -90,6 +90,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -262,7 +265,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap b/tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap index 3137f7a6..2e16832d 100644 --- a/tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap +++ b/tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap @@ -90,6 +90,9 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -262,7 +265,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap b/tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap index fabef2ca..0f9b78c3 100644 --- a/tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap +++ b/tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap @@ -76,6 +76,9 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -226,7 +229,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/view/with-options/for-ios/__snapshots__/create-view-with-options-for-ios.test.js.snap b/tests/with-injection/create/view/with-options/for-ios/__snapshots__/create-view-with-options-for-ios.test.js.snap index 0f6184d1..648da9c4 100644 --- a/tests/with-injection/create/view/with-options/for-ios/__snapshots__/create-view-with-options-for-ios.test.js.snap +++ b/tests/with-injection/create/view/with-options/for-ios/__snapshots__/create-view-with-options-for-ios.test.js.snap @@ -76,6 +76,9 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap b/tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap index 56ac964e..ca91b46e 100644 --- a/tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap +++ b/tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap @@ -86,6 +86,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -257,7 +260,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-defaults/bogus-platforms/bogus-name/__snapshots__/bogus-platforms-name.test.js.snap b/tests/with-injection/create/with-defaults/bogus-platforms/bogus-name/__snapshots__/bogus-platforms-name.test.js.snap index 2c46a8b4..26d15fa8 100644 --- a/tests/with-injection/create/with-defaults/bogus-platforms/bogus-name/__snapshots__/bogus-platforms-name.test.js.snap +++ b/tests/with-injection/create/with-defaults/bogus-platforms/bogus-name/__snapshots__/bogus-platforms-name.test.js.snap @@ -66,6 +66,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/with-defaults/bogus-platforms/empty-array/__snapshots__/bogus-platforms-empty-array.test.js.snap b/tests/with-injection/create/with-defaults/bogus-platforms/empty-array/__snapshots__/bogus-platforms-empty-array.test.js.snap index dfd6ea7d..ff2bcb01 100644 --- a/tests/with-injection/create/with-defaults/bogus-platforms/empty-array/__snapshots__/bogus-platforms-empty-array.test.js.snap +++ b/tests/with-injection/create/with-defaults/bogus-platforms/empty-array/__snapshots__/bogus-platforms-empty-array.test.js.snap @@ -66,6 +66,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/with-defaults/bogus-platforms/empty-string/__snapshots__/bogus-platforms-empty-string.test.js.snap b/tests/with-injection/create/with-defaults/bogus-platforms/empty-string/__snapshots__/bogus-platforms-empty-string.test.js.snap index 6dd9761a..fb7c98de 100644 --- a/tests/with-injection/create/with-defaults/bogus-platforms/empty-string/__snapshots__/bogus-platforms-empty-string.test.js.snap +++ b/tests/with-injection/create/with-defaults/bogus-platforms/empty-string/__snapshots__/bogus-platforms-empty-string.test.js.snap @@ -66,6 +66,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/with-example/for-android-only/__snapshots__/create-with-example-for-android-only.test.js.snap b/tests/with-injection/create/with-example/for-android-only/__snapshots__/create-with-example-for-android-only.test.js.snap index 0646d6af..6b97b2dc 100644 --- a/tests/with-injection/create/with-example/for-android-only/__snapshots__/create-with-example-for-android-only.test.js.snap +++ b/tests/with-injection/create/with-example/for-android-only/__snapshots__/create-with-example-for-android-only.test.js.snap @@ -80,6 +80,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -231,7 +234,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap b/tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap index 396dd214..8aa2a0a0 100644 --- a/tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap +++ b/tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap @@ -90,6 +90,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -262,7 +265,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap b/tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap index f23701c0..c1a80698 100644 --- a/tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap +++ b/tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap @@ -90,6 +90,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -262,7 +265,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap b/tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap index 7a4a82af..af840400 100644 --- a/tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap +++ b/tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap @@ -90,6 +90,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -262,7 +265,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap b/tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap index 2ff39152..2e26bb78 100644 --- a/tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap +++ b/tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap @@ -90,6 +90,9 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -262,7 +265,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap b/tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap index a10e21b2..bbcdf728 100644 --- a/tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap +++ b/tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap @@ -86,6 +86,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -257,7 +260,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap b/tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap index 3dbf521b..7864ae2f 100644 --- a/tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap +++ b/tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap @@ -76,6 +76,9 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.alicebits\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -226,7 +229,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.alicebits\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-options/for-ios/__snapshots__/create-with-options-for-ios.test.js.snap b/tests/with-injection/create/with-options/for-ios/__snapshots__/create-with-options-for-ios.test.js.snap index 06990c5a..80a10948 100644 --- a/tests/with-injection/create/with-options/for-ios/__snapshots__/create-with-options-for-ios.test.js.snap +++ b/tests/with-injection/create/with-options/for-ios/__snapshots__/create-with-options-for-ios.test.js.snap @@ -76,6 +76,9 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap b/tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap index ad36f0b1..8da25dfa 100644 --- a/tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap +++ b/tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap @@ -86,6 +86,9 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -257,7 +260,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap b/tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap index 6de2c091..a875446a 100644 --- a/tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap +++ b/tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap @@ -86,6 +86,9 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -257,7 +260,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap b/tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap index 67bb89e5..d9d27638 100644 --- a/tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap +++ b/tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap @@ -86,6 +86,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -257,7 +260,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap b/tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap index 1a3129be..7c27f6c4 100644 --- a/tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap +++ b/tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap @@ -86,6 +86,9 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -257,7 +260,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/bogus-name/__snapshots__/cli-command-with-bogus-platforms-name.test.js.snap b/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/bogus-name/__snapshots__/cli-command-with-bogus-platforms-name.test.js.snap index 5adea06a..18531c9c 100644 --- a/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/bogus-name/__snapshots__/cli-command-with-bogus-platforms-name.test.js.snap +++ b/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/bogus-name/__snapshots__/cli-command-with-bogus-platforms-name.test.js.snap @@ -101,6 +101,9 @@ AliceBobbi; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/empty-string/__snapshots__/cli-command-with-empty-platforms-string.test.js.snap b/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/empty-string/__snapshots__/cli-command-with-empty-platforms-string.test.js.snap index 478e65ea..0d841a2b 100644 --- a/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/empty-string/__snapshots__/cli-command-with-empty-platforms-string.test.js.snap +++ b/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/empty-string/__snapshots__/cli-command-with-empty-platforms-string.test.js.snap @@ -101,6 +101,9 @@ AliceBobbi; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap b/tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap index c8d219f7..126253fd 100644 --- a/tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap +++ b/tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap @@ -100,6 +100,9 @@ AliceBobbi; \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -261,7 +264,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap b/tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap index 73c84ffc..a2fd6b16 100644 --- a/tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap +++ b/tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap @@ -289,6 +289,9 @@ TestPackage; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -429,7 +432,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap index c902fb2b..a8173533 100644 --- a/tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap +++ b/tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap @@ -167,6 +167,9 @@ AliceBobbi; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -329,7 +332,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap index b76c1e48..4db3e009 100644 --- a/tests/with-mocks/lib/create/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap +++ b/tests/with-mocks/lib/create/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap @@ -167,6 +167,9 @@ AliceBobbi; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -329,7 +332,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap index 7d2a503e..f34b5e31 100644 --- a/tests/with-mocks/lib/create/with-example/with-logging/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap +++ b/tests/with-mocks/lib/create/with-example/with-logging/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap @@ -167,6 +167,9 @@ AliceBobbi; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.reactlibrary\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -329,7 +332,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.reactlibrary\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap index 35a6c863..0e8f32b4 100644 --- a/tests/with-mocks/lib/create/with-example/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap +++ b/tests/with-mocks/lib/create/with-example/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap @@ -161,6 +161,9 @@ ABCAliceBobbi; \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", + \\"android\\": { + \\"packageIdentifier\\": \\"com.alicebits\\" + }, \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -323,7 +326,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = \\"com.alicebits\\" + group = packageJson.android.packageIdentifier description packageJson.description url packageJson.repository.baseUrl From ade785f276831d6352101025eaccab6c9a26a4a9 Mon Sep 17 00:00:00 2001 From: "Christopher J. Brody" Date: Thu, 2 Apr 2020 11:19:41 -0400 Subject: [PATCH 4/6] Revert "make it `android` item with the `packageIdentifier` field in `package.json`" This reverts commit 4b320e9e68104fe1ba29e5c3c54167a8d6879cdb. --- templates/android.js | 2 +- templates/general.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/android.js b/templates/android.js index eedf4387..2eda81d5 100644 --- a/templates/android.js +++ b/templates/android.js @@ -84,7 +84,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.native.packageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/templates/general.js b/templates/general.js index 02ad7538..33b7e356 100644 --- a/templates/general.js +++ b/templates/general.js @@ -58,7 +58,7 @@ ${name}; "license": "${license}", "licenseFilename": "LICENSE", "readmeFilename": "README.md", - "android": { + "native": { "packageIdentifier": "${packageIdentifier}" }, "peerDependencies": ${peerDependencies}, From 5d6c7651243113fe885436a9fdfcaa59583f474d Mon Sep 17 00:00:00 2001 From: "Christopher J. Brody" Date: Thu, 2 Apr 2020 11:22:00 -0400 Subject: [PATCH 5/6] change to simple androidPackageIdentifier item in `package.json` --- templates/android.js | 2 +- templates/general.js | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/templates/android.js b/templates/android.js index 2eda81d5..399f4b0d 100644 --- a/templates/android.js +++ b/templates/android.js @@ -84,7 +84,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.native.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/templates/general.js b/templates/general.js index 33b7e356..e5f002a2 100644 --- a/templates/general.js +++ b/templates/general.js @@ -58,9 +58,7 @@ ${name}; "license": "${license}", "licenseFilename": "LICENSE", "readmeFilename": "README.md", - "native": { - "packageIdentifier": "${packageIdentifier}" - }, + "androidPackageIdentifier": "${packageIdentifier}", "peerDependencies": ${peerDependencies}, "devDependencies": ${devDependencies} } From 35ce549b8445516c9915aeb3d5080efe5e09b0df Mon Sep 17 00:00:00 2001 From: "Christopher J. Brody" Date: Thu, 2 Apr 2020 11:24:31 -0400 Subject: [PATCH 6/6] update test snapshots (again) --- .../view/__snapshots__/cli-create-with-view.test.js.snap | 6 ++---- .../__snapshots__/cli-create-with-defaults.test.js.snap | 6 ++---- .../__snapshots__/create-view-with-defaults.test.js.snap | 6 ++---- .../create-view-with-example-with-defaults.test.js.snap | 6 ++---- .../create-view-with-example-with-options.test.js.snap | 6 ++---- .../lib-view-android-config-options.test.js.snap | 6 ++---- .../create-view-with-options-for-ios.test.js.snap | 4 +--- .../__snapshots__/create-with-defaults.test.js.snap | 6 ++---- .../__snapshots__/bogus-platforms-name.test.js.snap | 4 +--- .../__snapshots__/bogus-platforms-empty-array.test.js.snap | 4 +--- .../__snapshots__/bogus-platforms-empty-string.test.js.snap | 4 +--- .../create-with-example-for-android-only.test.js.snap | 6 ++---- .../create-with-example-with-defaults.test.js.snap | 6 ++---- .../recover-from-missing-package-scripts.test.js.snap | 6 ++---- .../create-with-example-with-null-prefix.test.js.snap | 6 ++---- .../create-with-example-with-options.test.js.snap | 6 ++---- .../create-with-name-in-camel-case.test.js.snap | 6 ++---- .../create-with-options-for-android.test.js.snap | 6 ++---- .../__snapshots__/create-with-options-for-ios.test.js.snap | 4 +--- .../__snapshots__/platforms-array.test.js.snap | 6 ++---- .../__snapshots__/platforms-comma-separated.test.js.snap | 6 ++---- .../create-with-custom-module-prefix.test.js.snap | 6 ++---- .../__snapshots__/create-with-module-name.test.js.snap | 6 ++---- .../cli-command-with-bogus-platforms-name.test.js.snap | 4 +--- .../cli-command-with-empty-platforms-string.test.js.snap | 4 +--- .../cli-command-func-with-options.test.js.snap | 6 ++---- .../cli-program-with-defaults-for-android.test.js.snap | 6 ++---- .../create-with-example-with-defaults.test.js.snap | 6 ++---- .../__snapshots__/with-yarn-error-logging.test.js.snap | 6 ++---- .../create-with-example-with-options.test.js.snap | 6 ++---- .../create-with-example-with-options.test.js.snap | 6 ++---- 31 files changed, 55 insertions(+), 117 deletions(-) diff --git a/tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap b/tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap index 1c452dfa..e170bfcd 100644 --- a/tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap +++ b/tests/integration/cli/create/view/__snapshots__/cli-create-with-view.test.js.snap @@ -182,7 +182,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl @@ -667,9 +667,7 @@ RCT_EXPORT_MODULE() \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap b/tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap index b76e6a28..3aa415ff 100644 --- a/tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap +++ b/tests/integration/cli/create/with-defaults/__snapshots__/cli-create-with-defaults.test.js.snap @@ -182,7 +182,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl @@ -663,9 +663,7 @@ RCT_EXPORT_METHOD(sampleMethod:(NSString *)stringArgument numberParameter:(nonnu \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap b/tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap index 3a0e5465..9a486db9 100644 --- a/tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap +++ b/tests/with-injection/create/view/with-defaults/__snapshots__/create-view-with-defaults.test.js.snap @@ -86,9 +86,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -260,7 +258,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap b/tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap index 2c0ccc82..66860d89 100644 --- a/tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap +++ b/tests/with-injection/create/view/with-example/with-defaults/__snapshots__/create-view-with-example-with-defaults.test.js.snap @@ -90,9 +90,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -265,7 +263,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap b/tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap index 2e16832d..3e8a8167 100644 --- a/tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap +++ b/tests/with-injection/create/view/with-example/with-options/__snapshots__/create-view-with-example-with-options.test.js.snap @@ -90,9 +90,7 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -265,7 +263,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap b/tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap index 0f9b78c3..10dcc41b 100644 --- a/tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap +++ b/tests/with-injection/create/view/with-options/for-android/__snapshots__/lib-view-android-config-options.test.js.snap @@ -76,9 +76,7 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -229,7 +227,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/view/with-options/for-ios/__snapshots__/create-view-with-options-for-ios.test.js.snap b/tests/with-injection/create/view/with-options/for-ios/__snapshots__/create-view-with-options-for-ios.test.js.snap index 648da9c4..0db34cf2 100644 --- a/tests/with-injection/create/view/with-options/for-ios/__snapshots__/create-view-with-options-for-ios.test.js.snap +++ b/tests/with-injection/create/view/with-options/for-ios/__snapshots__/create-view-with-options-for-ios.test.js.snap @@ -76,9 +76,7 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap b/tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap index ca91b46e..681fc924 100644 --- a/tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap +++ b/tests/with-injection/create/with-defaults/__snapshots__/create-with-defaults.test.js.snap @@ -86,9 +86,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -260,7 +258,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-defaults/bogus-platforms/bogus-name/__snapshots__/bogus-platforms-name.test.js.snap b/tests/with-injection/create/with-defaults/bogus-platforms/bogus-name/__snapshots__/bogus-platforms-name.test.js.snap index 26d15fa8..f62d3cac 100644 --- a/tests/with-injection/create/with-defaults/bogus-platforms/bogus-name/__snapshots__/bogus-platforms-name.test.js.snap +++ b/tests/with-injection/create/with-defaults/bogus-platforms/bogus-name/__snapshots__/bogus-platforms-name.test.js.snap @@ -66,9 +66,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/with-defaults/bogus-platforms/empty-array/__snapshots__/bogus-platforms-empty-array.test.js.snap b/tests/with-injection/create/with-defaults/bogus-platforms/empty-array/__snapshots__/bogus-platforms-empty-array.test.js.snap index ff2bcb01..d76799df 100644 --- a/tests/with-injection/create/with-defaults/bogus-platforms/empty-array/__snapshots__/bogus-platforms-empty-array.test.js.snap +++ b/tests/with-injection/create/with-defaults/bogus-platforms/empty-array/__snapshots__/bogus-platforms-empty-array.test.js.snap @@ -66,9 +66,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/with-defaults/bogus-platforms/empty-string/__snapshots__/bogus-platforms-empty-string.test.js.snap b/tests/with-injection/create/with-defaults/bogus-platforms/empty-string/__snapshots__/bogus-platforms-empty-string.test.js.snap index fb7c98de..eaf2d75a 100644 --- a/tests/with-injection/create/with-defaults/bogus-platforms/empty-string/__snapshots__/bogus-platforms-empty-string.test.js.snap +++ b/tests/with-injection/create/with-defaults/bogus-platforms/empty-string/__snapshots__/bogus-platforms-empty-string.test.js.snap @@ -66,9 +66,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/with-example/for-android-only/__snapshots__/create-with-example-for-android-only.test.js.snap b/tests/with-injection/create/with-example/for-android-only/__snapshots__/create-with-example-for-android-only.test.js.snap index 6b97b2dc..83814f01 100644 --- a/tests/with-injection/create/with-example/for-android-only/__snapshots__/create-with-example-for-android-only.test.js.snap +++ b/tests/with-injection/create/with-example/for-android-only/__snapshots__/create-with-example-for-android-only.test.js.snap @@ -80,9 +80,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -234,7 +232,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap b/tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap index 8aa2a0a0..dab31313 100644 --- a/tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap +++ b/tests/with-injection/create/with-example/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap @@ -90,9 +90,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -265,7 +263,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap b/tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap index c1a80698..b5529090 100644 --- a/tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap +++ b/tests/with-injection/create/with-example/with-missing-package-scripts/__snapshots__/recover-from-missing-package-scripts.test.js.snap @@ -90,9 +90,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -265,7 +263,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap b/tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap index af840400..8998009e 100644 --- a/tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap +++ b/tests/with-injection/create/with-example/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-null-prefix.test.js.snap @@ -90,9 +90,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -265,7 +263,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap b/tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap index 2e26bb78..58d7a295 100644 --- a/tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap +++ b/tests/with-injection/create/with-example/with-options/__snapshots__/create-with-example-with-options.test.js.snap @@ -90,9 +90,7 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -265,7 +263,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap b/tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap index bbcdf728..ea0d0595 100644 --- a/tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap +++ b/tests/with-injection/create/with-name-in-camel-case/__snapshots__/create-with-name-in-camel-case.test.js.snap @@ -86,9 +86,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -260,7 +258,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap b/tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap index 7864ae2f..cc8c4a35 100644 --- a/tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap +++ b/tests/with-injection/create/with-options/for-android/__snapshots__/create-with-options-for-android.test.js.snap @@ -76,9 +76,7 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.alicebits\\" - }, + \\"androidPackageIdentifier\\": \\"com.alicebits\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -229,7 +227,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-options/for-ios/__snapshots__/create-with-options-for-ios.test.js.snap b/tests/with-injection/create/with-options/for-ios/__snapshots__/create-with-options-for-ios.test.js.snap index 80a10948..e7724284 100644 --- a/tests/with-injection/create/with-options/for-ios/__snapshots__/create-with-options-for-ios.test.js.snap +++ b/tests/with-injection/create/with-options/for-ios/__snapshots__/create-with-options-for-ios.test.js.snap @@ -76,9 +76,7 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap b/tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap index 8da25dfa..cf339268 100644 --- a/tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap +++ b/tests/with-injection/create/with-options/platforms-array/__snapshots__/platforms-array.test.js.snap @@ -86,9 +86,7 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -260,7 +258,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap b/tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap index a875446a..281daa46 100644 --- a/tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap +++ b/tests/with-injection/create/with-options/platforms-comma-separated/__snapshots__/platforms-comma-separated.test.js.snap @@ -86,9 +86,7 @@ content: \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -260,7 +258,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap b/tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap index d9d27638..fbdccc5a 100644 --- a/tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap +++ b/tests/with-injection/create/with-options/with-custom-module-prefix/__snapshots__/create-with-custom-module-prefix.test.js.snap @@ -86,9 +86,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -260,7 +258,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap b/tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap index 7c27f6c4..d60c65fe 100644 --- a/tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap +++ b/tests/with-injection/create/with-options/with-module-name/__snapshots__/create-with-module-name.test.js.snap @@ -86,9 +86,7 @@ content: \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -260,7 +258,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/bogus-name/__snapshots__/cli-command-with-bogus-platforms-name.test.js.snap b/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/bogus-name/__snapshots__/cli-command-with-bogus-platforms-name.test.js.snap index 18531c9c..128af52d 100644 --- a/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/bogus-name/__snapshots__/cli-command-with-bogus-platforms-name.test.js.snap +++ b/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/bogus-name/__snapshots__/cli-command-with-bogus-platforms-name.test.js.snap @@ -101,9 +101,7 @@ AliceBobbi; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/empty-string/__snapshots__/cli-command-with-empty-platforms-string.test.js.snap b/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/empty-string/__snapshots__/cli-command-with-empty-platforms-string.test.js.snap index 0d841a2b..acf83e71 100644 --- a/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/empty-string/__snapshots__/cli-command-with-empty-platforms-string.test.js.snap +++ b/tests/with-mocks/cli/command/func/with-logging/with-bogus-platforms/empty-string/__snapshots__/cli-command-with-empty-platforms-string.test.js.snap @@ -101,9 +101,7 @@ AliceBobbi; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" diff --git a/tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap b/tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap index 126253fd..c0931f84 100644 --- a/tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap +++ b/tests/with-mocks/cli/command/func/with-options/__snapshots__/cli-command-func-with-options.test.js.snap @@ -100,9 +100,7 @@ AliceBobbi; \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -264,7 +262,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap b/tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap index a2fd6b16..f465445f 100644 --- a/tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap +++ b/tests/with-mocks/cli/program/with-defaults/for-android/__snapshots__/cli-program-with-defaults-for-android.test.js.snap @@ -289,9 +289,7 @@ TestPackage; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -432,7 +430,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap index a8173533..d5ae15eb 100644 --- a/tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap +++ b/tests/with-mocks/lib/create/with-example/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap @@ -167,9 +167,7 @@ AliceBobbi; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -332,7 +330,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap index 4db3e009..62723a34 100644 --- a/tests/with-mocks/lib/create/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap +++ b/tests/with-mocks/lib/create/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap @@ -167,9 +167,7 @@ AliceBobbi; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -332,7 +330,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap index f34b5e31..384f2f28 100644 --- a/tests/with-mocks/lib/create/with-example/with-logging/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap +++ b/tests/with-mocks/lib/create/with-example/with-logging/with-null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap @@ -167,9 +167,7 @@ AliceBobbi; \\"license\\": \\"MIT\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.reactlibrary\\" - }, + \\"androidPackageIdentifier\\": \\"com.reactlibrary\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -332,7 +330,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl diff --git a/tests/with-mocks/lib/create/with-example/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap b/tests/with-mocks/lib/create/with-example/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap index 0e8f32b4..161f4764 100644 --- a/tests/with-mocks/lib/create/with-example/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap +++ b/tests/with-mocks/lib/create/with-example/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap @@ -161,9 +161,7 @@ ABCAliceBobbi; \\"license\\": \\"ISC\\", \\"licenseFilename\\": \\"LICENSE\\", \\"readmeFilename\\": \\"README.md\\", - \\"android\\": { - \\"packageIdentifier\\": \\"com.alicebits\\" - }, + \\"androidPackageIdentifier\\": \\"com.alicebits\\", \\"peerDependencies\\": { \\"react\\": \\"^16.8.1\\", \\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\" @@ -326,7 +324,7 @@ def configureReactNativePom(def pom) { name packageJson.title artifactId packageJson.name version = packageJson.version - group = packageJson.android.packageIdentifier + group = packageJson.androidPackageIdentifier description packageJson.description url packageJson.repository.baseUrl