Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect exit code when tests fail #285

Closed
vmcruz opened this issue Mar 23, 2022 · 2 comments
Closed

Incorrect exit code when tests fail #285

vmcruz opened this issue Mar 23, 2022 · 2 comments

Comments

@vmcruz
Copy link

vmcruz commented Mar 23, 2022

Whenever tests from cypress fail, I'd expect the exit code to be different than 0. Right now I'm getting success whether the tests fail or not. For instance:

Total tests: 37, passed: 34, failed: 3, skipped: 0
Done in 2856.008 seconds using 10 machines

It was reported as success. I'm currently using v1.13 with Cypress 9.4.1, but this happened with v1.12.1 and Cypress 8.7.1. Not sure if this is intended, but it doesn't feel correct for a CI tool.

Noticing this issue from 1.10 all the way through 1.13 (not sure if this was previously present). It might be worth mentioning that I'm using 10 machines with the parallel support.

Probably related to #170

@SachinMNair
Copy link

Hey Victor,

Thank you for raising this issue. We got it checked from our engineering team but they were not able to reproduce the issue that you have reported, attaching a screenshot for your reference.

Could you please raise a support ticket by dropping an email to [email protected] and share the build ID for which you are facing this issue so that we can check it from our end?
Screenshot 2022-03-24 at 11 50 55 AM

@vmcruz
Copy link
Author

vmcruz commented Mar 31, 2022

Oh gosh, this might be an issue within my script then. I'll run some tests and get back to you with my findings. I wrongly assumed this was related to that other issue with the exit codes. I'll close it for now and reopen if needed.

Thank you for the quick help.

@vmcruz vmcruz closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants