From bcda27686dde92c55536e3b61f0cb58ac2ad33af Mon Sep 17 00:00:00 2001 From: Hadi Sharghi Date: Tue, 18 Jun 2019 12:52:34 +0430 Subject: [PATCH 1/2] Fixed wrong exception class in function and PHPDoc --- src/Message/OptionsBuilder.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Message/OptionsBuilder.php b/src/Message/OptionsBuilder.php index d26e34302..bee2f2dea 100644 --- a/src/Message/OptionsBuilder.php +++ b/src/Message/OptionsBuilder.php @@ -160,12 +160,12 @@ public function setDelayWhileIdle($delayWhileIdle) * * @return \LaravelFCM\Message\OptionsBuilder * - * @throws InvalidOptionException + * @throws InvalidOptionsException */ public function setTimeToLive($timeToLive) { if ($timeToLive < 0 || $timeToLive > 2419200) { - throw new InvalidOptionException("time to live must be between 0 and 2419200, current value is: {$timeToLive}"); + throw new InvalidOptionsException("time to live must be between 0 and 2419200, current value is: {$timeToLive}"); } $this->timeToLive = $timeToLive; From 62f93c1df83738785e9f98788c56bfee37e39f39 Mon Sep 17 00:00:00 2001 From: Hadi Sharghi Date: Tue, 18 Jun 2019 12:53:57 +0430 Subject: [PATCH 2/2] Add @throws to PHPDoc for functions that throw exception --- src/Message/OptionsBuilder.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Message/OptionsBuilder.php b/src/Message/OptionsBuilder.php index bee2f2dea..1b5941d22 100644 --- a/src/Message/OptionsBuilder.php +++ b/src/Message/OptionsBuilder.php @@ -93,6 +93,7 @@ public function setCollapseKey($collapseKey) * @return \LaravelFCM\Message\OptionsBuilder * * @throws InvalidOptionsException + * @throws \ReflectionException */ public function setPriority($priority) { @@ -309,6 +310,8 @@ final class OptionsPriorities /** * @return array priorities available in fcm + * + * @throws \ReflectionException */ public static function getPriorities() { @@ -323,6 +326,8 @@ public static function getPriorities() * @param $priority * * @return bool + * + * @throws \ReflectionException */ public static function isValid($priority) {