Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type stubs #343

Open
tooruu opened this issue Jul 9, 2024 · 9 comments
Open

Add type stubs #343

tooruu opened this issue Jul 9, 2024 · 9 comments

Comments

@tooruu
Copy link

tooruu commented Jul 9, 2024

Please consider adding type stubs. Without static type information, it feels like walking in total darkness: no auto-completion, no types, no parameters, nor return values—nothing. It is very easy to introduce bugs, and you just can't predict what will happen in the code.

I made my own stubs based on PythonScript docs and Scintilla docs, but due to the lack of details and my zero prior experience with stubs, especially for code that interfaces with C++, I'm afraid they can't be fully correct without some help.

Let me know if you are interested in adding my type stubs to the project. I can open a pull request with the necessary changes for you to review.

@Ekopalypse
Copy link
Contributor

Afaik boost::python offers no possibility to create the pyi files automatically from the C++ sources. Another problem could be how to use PythonScript and where to place the resulting Npp.pyi file. Currently I create my stubs file by querying the Npp object itself.

@chcg
I'm not sure, but can we have a workflow action which starts Npp and the file would be created via the startup.py?

@tooruu
Copy link
Author

tooruu commented Jul 11, 2024

I place Npp.pyi in the Scripts directory of the plugin, where all script files reside. This way the IDE picks it up automatically during development.

@Ekopalypse
Copy link
Contributor

but if you use e.g. a local Python installation and pyls, then the search path knows nothing about PythonScript directories.

@alankilborn
Copy link

This way the IDE picks it up automatically

Which IDE?
The IDE I'd like to see do this (auto-completion, types, parameters, return values) is N++ itself. :-)

@tooruu
Copy link
Author

tooruu commented Jul 12, 2024

Which IDE?

PyCharm/VSC. IMO Notepad++ serves another purpose, and it's not worth making an IDE out of it.

@Ekopalypse
Copy link
Contributor

Now I'm confused, PythonScript is a Notepad++ plugin and its only purpose is to be used with Notepad++. So... why would someone use VSC, for example, to write a script to be used with Notepad++?

@alankilborn
Copy link

Notepad++ serves another purpose, and it's not worth making an IDE out of it.

I do my PythonScripting development with N++; PS dev doesn't really have power IDE features (e.g. debug), but it could more easily have the stuff being discussed in this issue. There are some other efforts underway, e.g. LSP...

@chcg
Copy link
Collaborator

chcg commented Oct 3, 2024

@Ekopalypse What is necessary to create such a pyi file? I think it is sufficient to create it together with my local runs of https://github.com/bruderstein/PythonScript/blob/master/PythonScript/src/CreateWrapper.py when syncs from N++ are done.

@Ekopalypse
Copy link
Contributor

@chcg - thank you for your continued commitment to the PythonScript project.

To create the stubs file, I use this script.

Without your recent changes, this would create an incorrect file.

image

Also, if you look at the code, you'll notice that NppReMatch is ignored because it looks like it's not being used by any Npp method.

Let me know if there is anything else I can help you with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants