Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable-media-replace plugin #6

Open
jdub233 opened this issue Mar 6, 2024 · 0 comments
Open

enable-media-replace plugin #6

jdub233 opened this issue Mar 6, 2024 · 0 comments
Assignees

Comments

@jdub233
Copy link
Contributor

jdub233 commented Mar 6, 2024

Problem

We are using an out-of-date fork of the Enable Media Replace plugin, and it doesn't work with the current S3 setup.

Solution 1

Switch to unmodified upstream vendor version: https://github.com/short-pixel-optimizer/enable-media-replace.

I was able to get the Short Pixel plugin at least halfway working with some modifications to bu-media-s3 and bu-cms.

Remaining issues with Short Pixel

  • The "rename then search and replace" option doesn't work, so I've disabled it. You can't select it, but it still shows up. So maybe practical but isn't perfect.
  • Ads are annoying, I have suppressed most but there is still one removable ad for a new feature that comes up the first time a plugin is used to replace a file.

Solution 2

Further develop the BU fork for S3 compatibility.

The old fork is substantially simpler than the newest vendor version, which seems to have had some bloat added. However, I don't know how much work it would take to get it working with the S3 setup. Also, if we keep using our own fork, we are on the hook for ongoing maintenance.

Status

I've created a build with the unmodified Short Pixel plugin (and compatibility and customization changes to bu-media-s3 and bu-cms) and deployed it to www-test. You can test it out there.

I've gathered the list of sites on www.bu.edu that have the emr plugin enabled and posted it here:
https://gist.github.com/jdub233/14068fe039c515cd1ea3680bd57699a2

@jdub233 jdub233 self-assigned this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant