Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label Field allows HTML like an <iframe>, horrible results ensue #112

Open
acketon opened this issue Feb 3, 2022 · 2 comments
Open

Label Field allows HTML like an <iframe>, horrible results ensue #112

acketon opened this issue Feb 3, 2022 · 2 comments
Labels
bug

Comments

@acketon
Copy link
Member

acketon commented Feb 3, 2022

Client sent a bug:
Screen Shot 2022-02-03 at 2 42 52 PM

Found this in the admin:
Screen Shot 2022-02-03 at 2 44 34 PM

uh-oh.

Label field should probably sanitize HTML? Or at least only allow a limited subset... certainly not <iframe>
Screen Shot 2022-02-03 at 2 44 53 PM
@acketon acketon added the bug label Feb 3, 2022
@acketon
Copy link
Member Author

acketon commented Feb 3, 2022

https://buweb.slack.com/archives/C08LCBE3D/p1643917410133739

@jdub233
Copy link
Contributor

jdub233 commented Feb 3, 2022

Probably adjusting this line would work:

bu-navigation/admin/post.php

Line 230 in 9c9ff65

$nav_label = wp_kses_post( $_POST['nav_label'] );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acketon @jdub233