Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with bu_navigation_list_pages #7

Open
mgburns opened this issue Mar 18, 2014 · 0 comments
Open

Issues with bu_navigation_list_pages #7

mgburns opened this issue Mar 18, 2014 · 0 comments
Labels

Comments

@mgburns
Copy link
Contributor

mgburns commented Mar 18, 2014

Logic errors in the bu_navigation_list_pages function are leading to unexpected behavior when using the "page_id" and "sections" arguments.

Example bug with "sections":

Given the following page tree:

  • Parent (ID=1)
    • Child (ID=2)
      • Grandchild 1 (ID=3)
      • Grandchild 2 (ID=4)

Calling bu_navigation_list_pages( array( 'sections' => array( 2, 1 ) ) should list all pages, but does not due to the ordering of the section post IDs.

Example bug with "page_id":

Given the same tree, calling bu_navigation_list_pages( array( 'page_id' => 3 ) ) will list ALL pages.

Somewhat related -- there is content navigation widget-specific logic tied up in this function that doesn't belong. (e.g. the "style" and "navigate_in_section" arguments). Cleanup would be nice.

@mgburns mgburns added the bug label Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant