From 751fef0eb86e08a371691318c7442cdccf22879c Mon Sep 17 00:00:00 2001 From: Todd Milliken Date: Tue, 2 Oct 2018 14:52:29 -0400 Subject: [PATCH 1/6] Bugfix: Fix typo in name of customizer filter MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Renames incorrectly typed filter name ‘responsive_the_title_classes’ to ‘responsive_the_title_class’ so the customizer field for hiding home page responsive_the_title tag adds a `u-visually-hidden` class if checked. --- inc/extras.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/extras.php b/inc/extras.php index a1616950..25245897 100755 --- a/inc/extras.php +++ b/inc/extras.php @@ -278,7 +278,7 @@ function responsive_maybe_hide_homepage_h1( $class ) { return $class; } -add_filter( 'responsive_the_title_classes', 'responsive_maybe_hide_homepage_h1', 10, 2 ); +add_filter( 'responsive_the_title_class', 'responsive_maybe_hide_homepage_h1', 10, 2 ); /** From 8f077e4105798f7cc5b58eb56710c3736b9399db Mon Sep 17 00:00:00 2001 From: Todd Milliken Date: Tue, 2 Oct 2018 14:57:13 -0400 Subject: [PATCH 2/6] Bugfix: Prevent empty post title from rendering Fixes bug in scenario where page/post never defines a title, resulting in an empty h1 tag. Now the empty h1 tag never outputs, and the title is validated to make sure its not empty before outputting. --- inc/template-tags.php | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/inc/template-tags.php b/inc/template-tags.php index ab3eb1d8..e18efbea 100755 --- a/inc/template-tags.php +++ b/inc/template-tags.php @@ -68,20 +68,31 @@ function responsive_the_title( $args = array() ) { // Allows class to be filtered. $args['class'] = (string) apply_filters( 'responsive_the_title_class', $args['class'] ); + // Stores the title. + $title = responsive_get_the_title(); + + // Returns immediately if no title. + if ( empty( $title ) ) { + return; + } + // Builds the h1 tag. if ( ! empty( $args['class'] ) ) { - $html = '

' . responsive_get_the_title() . '

'; + $html = '

' . $title . '

'; } else { - $html = '

' . responsive_get_the_title() . '

'; + $html = '

' . $title . '

'; } // Echoes or returns the html. if ( $args['echo'] ) { - echo wp_kses( $html, array( - 'h1' => array( - 'class' => array(), - ), - ) ); + echo wp_kses( + $html, + array( + 'h1' => array( + 'class' => array(), + ), + ) + ); } else { return $html; } From eb37af3f56f75f359d7d85596655925282d4b6d4 Mon Sep 17 00:00:00 2001 From: Todd Milliken Date: Tue, 2 Oct 2018 15:06:20 -0400 Subject: [PATCH 3/6] Update CHANGELOG to use level 2 headings --- CHANGELOG.md | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e3d4c6d8..90625cf8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Changelog -# 2.1.8 +## 2.1.8 - Added new template tag, `responsive_the_title()`, intended to output the page title for each single post/page template. @@ -11,15 +11,15 @@ the responsive-framework page title. to use an h1 element with the current page title if the banner title is left empty. -# 2.1.7 +## 2.1.7 - Add "Eiffel" and "Comm Ave" color themes to customizer. -# 2.1.6 +## 2.1.6 - Fixes count of widgets on alternative footbar. -# 2.1.5 +## 2.1.5 - Refactored `page-templates/calendar.php` for easier child-theming by separating logic into functions that now live in the existing `/inc/calendar.php` functions file, and moving templating chunks into `template-parts/calendar/calendar.php` and @@ -30,26 +30,26 @@ with `network_home_url` in the `responsive_is_bu_domain` function defined in `inc/template-tags.php:33`. -# 2.1.4 +## 2.1.4 - Adds skip link support. -# 2.1.3 +## 2.1.3 - Added `responsive_is_wpdocs()`, to check for the wpdocs subdomain. -# 2.1.4 +## 2.1.4 - Color contrast accessibility fixes to comply with MWAS - Added skip-link feature for keyboard navigation -# 2.1.3 +## 2.1.3 - Added BU Hub Indicator. Incorporated adjustments to line height. -# 2.1.2 +## 2.1.2 - Move 2.1.2 to a new repo for a fresh start in prepartion to begin the open source process. -# 2.0.0 +## 2.0.0 - Added CONTRIBUTING.md file for contribution rules. - Removed use of `file_get_contents()` in the Customizer. From 8946ddf8551beb6d2e220548b04d75eec1d2fe47 Mon Sep 17 00:00:00 2001 From: Todd Milliken Date: Tue, 2 Oct 2018 15:06:59 -0400 Subject: [PATCH 4/6] Update CHANGELOG with bugfix notes --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 90625cf8..b53efd36 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## Unreleased + +- Bugfix: Prevented empty post title from rendering in `responsive_the_title()` template tag. +- Bugfix: Fixed typo in name of filter used to visually hide home page title. Was `responsive_the_title_classes` and is now `responsive_the_title_class`. + ## 2.1.8 - Added new template tag, `responsive_the_title()`, intended to output the page title From 10feab2368049d74549a18a7e29f9517acc9dc4c Mon Sep 17 00:00:00 2001 From: Todd Milliken Date: Wed, 3 Oct 2018 13:50:27 -0400 Subject: [PATCH 5/6] Fix multiple Code Climate issues on CHANGELOG MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Adjusts all line-length to be 80 characters (Thanks to VS Code “rewrap” extension and selecting all text and running “Rewrap comment/text” with my editor set to 80 characters) - Adds blank lines around each header - Fixes spaces after list markers to be only 1 space - Consolidated duplicated heading entries for 2.1.3 and 2.1.4 --- CHANGELOG.md | 483 ++++++++++++++++++++++++++------------------------- 1 file changed, 250 insertions(+), 233 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b53efd36..6f8fe058 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,332 +2,349 @@ ## Unreleased -- Bugfix: Prevented empty post title from rendering in `responsive_the_title()` template tag. -- Bugfix: Fixed typo in name of filter used to visually hide home page title. Was `responsive_the_title_classes` and is now `responsive_the_title_class`. +- Bugfix: Prevented empty post title from rendering in `responsive_the_title()` + template tag. +- Bugfix: Fixed typo in name of filter used to visually hide home page title. + Was `responsive_the_title_classes` and is now `responsive_the_title_class`. ## 2.1.8 -- Added new template tag, `responsive_the_title()`, intended to output the page title - for each single post/page template. -- Added new filter to the new `responsive_the_title()` template_tag, named `responsive_filter_the_title` - which can be used to modify/prevent the output of page titles in responsive-framework. -- Added new functions partial `/inc/bu-banners.php` to provide additional support features for bu-banners - plugin. Currently adds the h1 page title to banner if exists and title field is empty, and suppresses - the responsive-framework page title. - to use an h1 element with the current page title if the banner title is left empty. +- Added new template tag, `responsive_the_title()`, intended to output the page + title for each single post/page template. +- Added new filter to the new `responsive_the_title()` template_tag, named + `responsive_filter_the_title` which can be used to modify/prevent the output + of page titles in responsive-framework. +- Added new functions partial `/inc/bu-banners.php` to provide additional + support features for bu-banners plugin. Currently adds the h1 page title to + banner if exists and title field is empty, and suppresses the + responsive-framework page title. to use an h1 element with the current page + title if the banner title is left empty. ## 2.1.7 -- Add "Eiffel" and "Comm Ave" color themes to customizer. +- Add "Eiffel" and "Comm Ave" color themes to customizer. ## 2.1.6 -- Fixes count of widgets on alternative footbar. +- Fixes count of widgets on alternative footbar. ## 2.1.5 -- Refactored `page-templates/calendar.php` for easier child-theming by separating logic - into functions that now live in the existing `/inc/calendar.php` functions file, and - moving templating chunks into `template-parts/calendar/calendar.php` and - `template-parts/calendar/single-event.php`. -- Added new filter for calendar template for changing hardcoded labels on the - `template-parts/calendar/single-event.php` partial, named `responsive_calendar_event_labels`. -- Resolved fatal error in single-site installs by replacing `get_current_site` - with `network_home_url` in the `responsive_is_bu_domain` function defined in - `inc/template-tags.php:33`. -## 2.1.4 -- Adds skip link support. - -## 2.1.3 -- Added `responsive_is_wpdocs()`, to check for the wpdocs subdomain. +- Refactored `page-templates/calendar.php` for easier child-theming by + separating logic into functions that now live in the existing + `/inc/calendar.php` functions file, and moving templating chunks into + `template-parts/calendar/calendar.php` and + `template-parts/calendar/single-event.php`. +- Added new filter for calendar template for changing hardcoded labels on the + `template-parts/calendar/single-event.php` partial, named + `responsive_calendar_event_labels`. +- Resolved fatal error in single-site installs by replacing `get_current_site` + with `network_home_url` in the `responsive_is_bu_domain` function defined in + `inc/template-tags.php:33`. ## 2.1.4 -- Color contrast accessibility fixes to comply with MWAS -- Added skip-link feature for keyboard navigation +- Adds skip link support. +- Color contrast accessibility fixes to comply with MWAS +- Added skip-link feature for keyboard navigation ## 2.1.3 -- Added BU Hub Indicator. Incorporated adjustments to line height. +- Added `responsive_is_wpdocs()`, to check for the wpdocs subdomain. +- Added BU Hub Indicator. Incorporated adjustments to line height. ## 2.1.2 -- Move 2.1.2 to a new repo for a fresh start in prepartion to begin the open source process. +- Move 2.1.2 to a new repo for a fresh start in prepartion to begin the open + source process. ## 2.0.0 -- Added CONTRIBUTING.md file for contribution rules. -- Removed use of `file_get_contents()` in the Customizer. -- Responsive Framework "header" templates are now renamed to "masthead" - templates to avoid confusion with WordPress core's header template - functionality. -- Page templates have been updated to be more simple. A template part should be - a repeatable chunk that can be used within the loop. All logic determining - what should show, how, or where, should be contained in the page template. -- For most post types, single templates only display content in one way. For - that reason, single templates should not use `get_template_part()` unless more - than one display variations actually exist. -- Updated profile, news, and page templates to use the above thought process. -- `responsive_post_lists_show_news_meta()` no longer requires a settings array - to be passed when called. By default, it will utilize the settings selected on - the news page. An array of settings different form those selected can still be - passed. -- Introduce several action hooks to make it easier for child themes to inject - markup without having to copy the entire template file. Hooks introduced: - - `r_after_opening_body_tag` - - `r_before_opening_wrapper` - - `r_after_opening_wrapper` - - `r_before_opening_container_outer` - - `r_after_opening_container_outer` - - `r_before_opening_container_inner` - - `r_after_opening_container_inner` - - `r_before_masthead` - - `r_after_masthead` - - `r_before_closing_container_inner` - - `r_after_closing_container_inner` - - `r_before_closing_container_outer` - - `r_after_closing_container_outer` - - `r_before_closing_wrapper` - - `r_after_closing_wrapper` - - `r_before_branding_masterplate` - - `r_after_branding_masterplate` - - `r_before_bumc_branding_logo` - - `r_after_bumc_branding_logo` - - `r_before_branding_disclaimer` - - `r_after_branding_disclaimer` - - ~~`r_before_content_banner_{position}`~~ - - ~~`r_before_content_banner`~~ - - ~~`r_after_content_banner_{position}`~~ - - ~~`r_after_content_banner`~~ -- ~~Added `r_content_banner_args` filter for modifying generated content banner - arguments.~~ -- ~~Added `r_content_banner_output` filter for modifying content banner output. - This was previously `responsive_content_banner_output`.~~ -- Add `branding.php` template part so child themes can override the default - branding markup by calling `remove_theme_support( 'bu-branding' )`. -- Add `r_script_in_footer` filter for changing the loading location of the - theme's JavaScript file. -- Add `r_enqueue_modernizr` filter for preventing Modernizr from being - enqueued. Child themes and plugins can use this to load their own build of - Modernizr. -- Add video autoplay to the list of Modernizr checks. -- Introduce `r_get_template_part()`. Adds the ability to theme a specific post - type's display in archive contexts within a child theme without having to - change the `archive.php` template that serves as the default for all archive - pages. For more details see [102e38a](https://github.com/bu-ist/responsive-framework/pull/153/commits/102e38aa79a6d42bd782d5d4be5c1d3f20fc5b83). -- Introduce `r_get_archive_sidebar()`. Adds the ability to theme sidebars for - specific archive contexts without having to change the `archive.php` template - in a child theme. For more details see [55f3602](https://github.com/bu-ist/responsive-framework/pull/153/commits/55f3602dc496439d414f28a24b72dd6e19edec99). -- Update `responsive_term_links()` to act as a wrapper of `get_the_term_list()` - to solve several issues. See [#185](https://github.com/bu-ist/responsive-framework/issues/185). -- Set up unit testing with Travis CI with an initial test suite. These should be - updated and maintained with every pull request. -- Set up Code Climate test coverage reporting. -- Make sure `post_class()` is used for every container of every post, - regardless of post type. -- Comment message field is now marked required. The browser will now notify the - commenter when they try to submit the form if the field is empty. -- Ensure `role="main"` is used properly and adheres to the proper accessibility - standards. -- Add HTML5 required attributes to comment form elements and require comments. -- Fixes a longstanding issue with the left navigation layout where pages with - little to no content would cut off the navigation. -- Remove unnecessary gravatars markup. -- Clarifies the use of Footer Additional Information in the Customizer. -- Adds a new class, `content-area`, for styling what was formerly - `article[role=main]`. -- Moves `profiles.php` to the root of the theme directory from `/page-templates` - to allow users to select which profile format to use on the profiles template. -- Introduce `r_container_inner_class()` for displaying the class attribute for - the inner content container element. Classes are filterable through the - `r_container_inner_class` filter. -- Introduce `r_container_outer_class()` for displaying the class attribute for - the outer content container element. Classes are filterable through the - `r_container_outer_class` filter. -- Fetch the `.mdlrc` and `markdown.rb` files from the [coding standards repository](https://github.com/bu-ist/coding-standards/tree/master). -- Restructured HTML and added CSS classes in the footer for cleaner branding - styles. -- Add extra classes to `post_class()` based on template part and template type. -- Introduces unique classes to output HTML based on content type and scope of - styles. For example, a title on the new calendar widget classes using the graphic - format will have both `.widget-calendar-title` and `.widget-calendar-title-graphic`, - which makes it clearer exactly which content is affected when overriding a class. -- Smarter use of CSS inheritance in the fonts and color palette CSS generated byline - Customizer. -- Introduces a class for the first calendar event at a time in a long list of times. -- Cleans up unnecessary wrapper HTML from Flexi Framework. -- Major improvements to the default course feeds template, which now link to - building location, show course instructors, fix the broken course type and display - as a whole word instead of an abbreviation, display semester availability, - display prerequisites for the course, and removes the cryptic course ID in favor - of a clearer display of section ID, semester, and year. -- Adds unique callbacks for calendar widget formats and updates tags to HTML5. -- Adds a lightbox for galleries automatically. -- Add a page template dropdown filter to the top of the page admin screen. -- Switches `content-container` class to a plain div inside of `main`, which enables - you to use this class as many times as you need to, such as in a landing page. -- UI improvements: "Layout" is now called "Navigation Style" in Customizer to - avoid future conflicts with a potential layout builder and clarify functionality. -- Underscores are no longer stripped from classes in HTML. -- Title attributes have been removed from anchor tags to promote accessibility. -- Upgrade Modernizr and add new tests: sticky, video autoplay. -- Deactivate the BU Mobile plugin when the theme is activated. -- Introduce pull request and issue templates. -- Add `` element support detection to Modernizr. -- Prepare the theme for localization using internationalization best practices. -- Remove `bu_search_form_query_attributes` filter function. This is now the - default behavior in BU-CMS. -- Remove Content Banner support. -- Add Grunt time reporting. -- Rename `content-none.php` to `no-content.php`. +- Added CONTRIBUTING.md file for contribution rules. +- Removed use of `file_get_contents()` in the Customizer. +- Responsive Framework "header" templates are now renamed to "masthead" + templates to avoid confusion with WordPress core's header template + functionality. +- Page templates have been updated to be more simple. A template part should be + a repeatable chunk that can be used within the loop. All logic determining + what should show, how, or where, should be contained in the page template. +- For most post types, single templates only display content in one way. For + that reason, single templates should not use `get_template_part()` unless more + than one display variations actually exist. +- Updated profile, news, and page templates to use the above thought process. +- `responsive_post_lists_show_news_meta()` no longer requires a settings array + to be passed when called. By default, it will utilize the settings selected on + the news page. An array of settings different form those selected can still be + passed. +- Introduce several action hooks to make it easier for child themes to inject + markup without having to copy the entire template file. Hooks introduced: + - `r_after_opening_body_tag` + - `r_before_opening_wrapper` + - `r_after_opening_wrapper` + - `r_before_opening_container_outer` + - `r_after_opening_container_outer` + - `r_before_opening_container_inner` + - `r_after_opening_container_inner` + - `r_before_masthead` + - `r_after_masthead` + - `r_before_closing_container_inner` + - `r_after_closing_container_inner` + - `r_before_closing_container_outer` + - `r_after_closing_container_outer` + - `r_before_closing_wrapper` + - `r_after_closing_wrapper` + - `r_before_branding_masterplate` + - `r_after_branding_masterplate` + - `r_before_bumc_branding_logo` + - `r_after_bumc_branding_logo` + - `r_before_branding_disclaimer` + - `r_after_branding_disclaimer` + - ~~`r_before_content_banner_{position}`~~ + - ~~`r_before_content_banner`~~ + - ~~`r_after_content_banner_{position}`~~ + - ~~`r_after_content_banner`~~ +- ~~Added `r_content_banner_args` filter for modifying generated content banner + arguments.~~ +- ~~Added `r_content_banner_output` filter for modifying content banner output. + This was previously `responsive_content_banner_output`.~~ +- Add `branding.php` template part so child themes can override the default + branding markup by calling `remove_theme_support( 'bu-branding' )`. +- Add `r_script_in_footer` filter for changing the loading location of the + theme's JavaScript file. +- Add `r_enqueue_modernizr` filter for preventing Modernizr from being enqueued. + Child themes and plugins can use this to load their own build of Modernizr. +- Add video autoplay to the list of Modernizr checks. +- Introduce `r_get_template_part()`. Adds the ability to theme a specific post + type's display in archive contexts within a child theme without having to + change the `archive.php` template that serves as the default for all archive + pages. For more details see + [102e38a](https://github.com/bu-ist/responsive-framework/pull/153/commits/102e38aa79a6d42bd782d5d4be5c1d3f20fc5b83). +- Introduce `r_get_archive_sidebar()`. Adds the ability to theme sidebars for + specific archive contexts without having to change the `archive.php` template + in a child theme. For more details see + [55f3602](https://github.com/bu-ist/responsive-framework/pull/153/commits/55f3602dc496439d414f28a24b72dd6e19edec99). +- Update `responsive_term_links()` to act as a wrapper of `get_the_term_list()` + to solve several issues. See + [#185](https://github.com/bu-ist/responsive-framework/issues/185). +- Set up unit testing with Travis CI with an initial test suite. These should be + updated and maintained with every pull request. +- Set up Code Climate test coverage reporting. +- Make sure `post_class()` is used for every container of every post, regardless + of post type. +- Comment message field is now marked required. The browser will now notify the + commenter when they try to submit the form if the field is empty. +- Ensure `role="main"` is used properly and adheres to the proper accessibility + standards. +- Add HTML5 required attributes to comment form elements and require comments. +- Fixes a longstanding issue with the left navigation layout where pages with + little to no content would cut off the navigation. +- Remove unnecessary gravatars markup. +- Clarifies the use of Footer Additional Information in the Customizer. +- Adds a new class, `content-area`, for styling what was formerly + `article[role=main]`. +- Moves `profiles.php` to the root of the theme directory from `/page-templates` + to allow users to select which profile format to use on the profiles template. +- Introduce `r_container_inner_class()` for displaying the class attribute for + the inner content container element. Classes are filterable through the + `r_container_inner_class` filter. +- Introduce `r_container_outer_class()` for displaying the class attribute for + the outer content container element. Classes are filterable through the + `r_container_outer_class` filter. +- Fetch the `.mdlrc` and `markdown.rb` files from the [coding standards + repository](https://github.com/bu-ist/coding-standards/tree/master). +- Restructured HTML and added CSS classes in the footer for cleaner branding + styles. +- Add extra classes to `post_class()` based on template part and template type. +- Introduces unique classes to output HTML based on content type and scope of + styles. For example, a title on the new calendar widget classes using the + graphic format will have both `.widget-calendar-title` and + `.widget-calendar-title-graphic`, which makes it clearer exactly which content + is affected when overriding a class. +- Smarter use of CSS inheritance in the fonts and color palette CSS generated + byline Customizer. +- Introduces a class for the first calendar event at a time in a long list of + times. +- Cleans up unnecessary wrapper HTML from Flexi Framework. +- Major improvements to the default course feeds template, which now link to + building location, show course instructors, fix the broken course type and + display as a whole word instead of an abbreviation, display semester + availability, display prerequisites for the course, and removes the cryptic + course ID in favor of a clearer display of section ID, semester, and year. +- Adds unique callbacks for calendar widget formats and updates tags to HTML5. +- Adds a lightbox for galleries automatically. +- Add a page template dropdown filter to the top of the page admin screen. +- Switches `content-container` class to a plain div inside of `main`, which + enables you to use this class as many times as you need to, such as in a + landing page. +- UI improvements: "Layout" is now called "Navigation Style" in Customizer to + avoid future conflicts with a potential layout builder and clarify + functionality. +- Underscores are no longer stripped from classes in HTML. +- Title attributes have been removed from anchor tags to promote accessibility. +- Upgrade Modernizr and add new tests: sticky, video autoplay. +- Deactivate the BU Mobile plugin when the theme is activated. +- Introduce pull request and issue templates. +- Add `` element support detection to Modernizr. +- Prepare the theme for localization using internationalization best practices. +- Remove `bu_search_form_query_attributes` filter function. This is now the + default behavior in BU-CMS. +- Remove Content Banner support. +- Add Grunt time reporting. +- Rename `content-none.php` to `no-content.php`. ## 1.5.6 -- Remove empty IE conditional at the beginning of `header.php` ([#272](https://github.com/bu-ist/responsive-framework/issues/272)). -- Ensure the correct default value is returned for - `BU_RESPONSIVE_POSTS_SIDEBAR_SHOW_BOTTOM` ([#268](https://github.com/bu-ist/responsive-framework/pull/268)). +- Remove empty IE conditional at the beginning of `header.php` + ([#272](https://github.com/bu-ist/responsive-framework/issues/272)). +- Ensure the correct default value is returned for + `BU_RESPONSIVE_POSTS_SIDEBAR_SHOW_BOTTOM` + ([#268](https://github.com/bu-ist/responsive-framework/pull/268)). ## 1.5.5 -- Fix bug where nav toggle icon was not receiving the correct color (#251). +- Fix bug where nav toggle icon was not receiving the correct color (#251). ## 1.5.4 -- Enables pinch to zoom for accessibility on mobile. -- Fixes a bug where BUMC branding styles do not apply correctly. -- Add `right` default to `burf_setting_sidebar_location` option. +- Enables pinch to zoom for accessibility on mobile. +- Fixes a bug where BUMC branding styles do not apply correctly. +- Add `right` default to `burf_setting_sidebar_location` option. ## 1.5.3 -- Move the body `id` declaration in front of `class`. +- Move the body `id` declaration in front of `class`. ## 1.5.2 -- Fix `responsive_maybe_hide_homepage_h1()` to accept the second parameter for - `the_title` filter. -- Introduce the `r_script_dependencies` filter. Used to filter script - dependencies for child theme script files. +- Fix `responsive_maybe_hide_homepage_h1()` to accept the second parameter for + `the_title` filter. +- Introduce the `r_script_dependencies` filter. Used to filter script + dependencies for child theme script files. ## 1.4.3 -- Fix for BUniverse embeds/shortcode to support HTTPS. +- Fix for BUniverse embeds/shortcode to support HTTPS. ## 1.4.2 -- Updating to newest tag (1.3.2) of Responsive Foundation +- Updating to newest tag (1.3.2) of Responsive Foundation ## 1.4.1 -- Updating to newest tag (1.3.0) of Responsive Foundation +- Updating to newest tag (1.3.0) of Responsive Foundation ## 1.4.0 -- Calendar api update: enabling monthly dropdown menu & topic heading text -- Search form & search form accessibility improvements -- Branding updates -- Customizer Layout & Fonts bug fix (#43) +- Calendar api update: enabling monthly dropdown menu & topic heading text +- Search form & search form accessibility improvements +- Branding updates +- Customizer Layout & Fonts bug fix (#43) ## 1.3.5 -- Fixing post display options array [Commit](https://github.com/bu-ist/responsive-framework/commit/dd72447ea1e54b5ee7ba572a00b82d4c1691321e) -- Update to [Responsive Foundation 1.2.1](https://github.com/bu-ist/responsive-foundation/releases/tag/1.2.1) +- Fixing post display options array + [Commit](https://github.com/bu-ist/responsive-framework/commit/dd72447ea1e54b5ee7ba572a00b82d4c1691321e) +- Update to [Responsive Foundation + 1.2.1](https://github.com/bu-ist/responsive-foundation/releases/tag/1.2.1) ## 1.3.4-beta -- Create new gravity forms contact forms only when necessary. - - They should be generated only when current site has contact forms using the - Contact Us plugin. - - Previous bug: gravity forms were generated for sites without contact forms. - And if the theme got activated multiple times, more gravity forms were - generated each time. +- Create new gravity forms contact forms only when necessary. + - They should be generated only when current site has contact forms using + the Contact Us plugin. + - Previous bug: gravity forms were generated for sites without contact + forms. And if the theme got activated multiple times, more gravity forms + were generated each time. ## 1.3.3-beta -- Updating to Responsive Foundation 1.2.0 (Bunnies) +- Updating to Responsive Foundation 1.2.0 (Bunnies) ## 1.3.2-beta -- Add filter to responsive_content_banner to manipulate output on theme level +- Add filter to responsive_content_banner to manipulate output on theme level ## 1.3.1-beta -- Add `no-access.php` and no-access-bumc.php` template files to framework for - Audience plugin on bumc.bu.edu +- Add `no-access.php` and no-access-bumc.php` template files to framework for + Audience plugin on bumc.bu.edu ## 1.3.0-beta -- Responsi-as-a-Service beta release -- Enable Customizer font palettes for non-child themes -- Enable Customizer color palettes for non-child themes -- Add Customizer display options for toggling visibility of post meta fields -- Add Customizer sidebar options for toggling usage of alternate footbars -- Update footer branding styles to support BUMC logo, disclaimer link -- Update site initialization / automated Flexi migration logic +- Responsi-as-a-Service beta release +- Enable Customizer font palettes for non-child themes +- Enable Customizer color palettes for non-child themes +- Add Customizer display options for toggling visibility of post meta fields +- Add Customizer sidebar options for toggling usage of alternate footbars +- Update footer branding styles to support BUMC logo, disclaimer link +- Update site initialization / automated Flexi migration logic ## 1.2.2 -- Add fallback for branding +- Add fallback for branding ## 1.2.1 -- Change empty value for calendar event time from ' ' to '' -- Add site initialization and Flexi migration logic (dormant pending release of - Site Manager 4.0.0) -- Fix #30: Don't display search icon when search is disabled -- Fix #32: Don't override threaded comment depth set via Settings > Discussion -- Fix #19: Update social media icons to add alternate icons, fix issues with - Flickr / Vine and Google+. See [a304709](https://github.com/bu-ist/responsive-foundation/commit/a30470947bc5bf05533e183e31f2060dd89d99c2). -- Fix typo with archive button. +- Change empty value for calendar event time from ' ' to '' +- Add site initialization and Flexi migration logic (dormant pending release of + Site Manager 4.0.0) +- Fix #30: Don't display search icon when search is disabled +- Fix #32: Don't override threaded comment depth set via Settings > Discussion +- Fix #19: Update social media icons to add alternate icons, fix issues with + Flickr / Vine and Google+. See + [a304709](https://github.com/bu-ist/responsive-foundation/commit/a30470947bc5bf05533e183e31f2060dd89d99c2). +- Fix typo with archive button. ## 1.2.0 -- Add support for BU Branding plugin -- Add template tags for display of BUMC logo and disclaimer -- Add support for BU Sharing plugin -- Introduce `responsive_share_tools()` for share tools display -- Ensure Customizer is accessible to non-super admin -- Remove shims for BU Profiles / Content Banner template tags that have been - integrated into plugins -- Add hooks to upgrade function to support pending migration of Research theme +- Add support for BU Branding plugin +- Add template tags for display of BUMC logo and disclaimer +- Add support for BU Sharing plugin +- Introduce `responsive_share_tools()` for share tools display +- Ensure Customizer is accessible to non-super admin +- Remove shims for BU Profiles / Content Banner template tags that have been + integrated into plugins +- Add hooks to upgrade function to support pending migration of Research theme ## 1.1.0 -- Add basic BUniverse embed provider -- Archive template now utilizes profile template parts for profile-specific - taxonomy archives (#22) -- Profile shortcode templates now utilize template partials -- Navigation template tags now support customizable labels and screen reader - text (#23) -- Navigation template tags are now post type-agnostic -- Fix posts navigation button placement (they were reversed) -- Fix #18: Empty

tags when no post meta exists for News template -- Fix #21: Use correct class attribute for `[buniverse]` shortcode -- Introduce `responsive_archive_type()` and `responsive_queried_post_types()` - helpers (#22) -- Deprecate `responsive_paging_nav()` in favor of - `responsive_posts_navigation()` -- Deprecate `responsive_post_nav()` in favor of `responsive_post_navigation()` +- Add basic BUniverse embed provider +- Archive template now utilizes profile template parts for profile-specific + taxonomy archives (#22) +- Profile shortcode templates now utilize template partials +- Navigation template tags now support customizable labels and screen reader + text (#23) +- Navigation template tags are now post type-agnostic +- Fix posts navigation button placement (they were reversed) +- Fix #18: Empty

tags when no post meta exists for News template +- Fix #21: Use correct class attribute for `[buniverse]` shortcode +- Introduce `responsive_archive_type()` and `responsive_queried_post_types()` + helpers (#22) +- Deprecate `responsive_paging_nav()` in favor of + `responsive_posts_navigation()` +- Deprecate `responsive_post_nav()` in favor of `responsive_post_navigation()` ## 1.0.3 -- Update to [Responsive Foundation 1.0.3](https://github.com/bu-ist/responsive-foundation/releases/tag/1.0.3) +- Update to [Responsive Foundation + 1.0.3](https://github.com/bu-ist/responsive-foundation/releases/tag/1.0.3) ## 1.0.2 -- Add href to BU masterplate +- Add href to BU masterplate ## 1.0.1 -- Add shortcode parsing for core text widgets -- Fix footbar position in sideNav layout -- Refactored header markup +- Add shortcode parsing for core text widgets +- Fix footbar position in sideNav layout +- Refactored header markup ## 1.0.0 -- Deemed stable for child theme development +- Deemed stable for child theme development ## 0.9.1 -- Pre-release version of Responsi. -- Child themes based on 0.9.1 include: r-cfa, r-hr, r-pardeeschool, r-research, - and r-school. +- Pre-release version of Responsi. +- Child themes based on 0.9.1 include: r-cfa, r-hr, r-pardeeschool, r-research, + and r-school. From 2b7ebb1d3f02a4ef168cb0edbdf8381e6f91ba8a Mon Sep 17 00:00:00 2001 From: Todd Milliken Date: Wed, 3 Oct 2018 14:04:58 -0400 Subject: [PATCH 6/6] Fix CHANGELOG nested ul indendation Use two spaces instead of 4 for Code Climate --- CHANGELOG.md | 60 ++++++++++++++++++++++++++-------------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6f8fe058..a66ca949 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -78,31 +78,31 @@ passed. - Introduce several action hooks to make it easier for child themes to inject markup without having to copy the entire template file. Hooks introduced: - - `r_after_opening_body_tag` - - `r_before_opening_wrapper` - - `r_after_opening_wrapper` - - `r_before_opening_container_outer` - - `r_after_opening_container_outer` - - `r_before_opening_container_inner` - - `r_after_opening_container_inner` - - `r_before_masthead` - - `r_after_masthead` - - `r_before_closing_container_inner` - - `r_after_closing_container_inner` - - `r_before_closing_container_outer` - - `r_after_closing_container_outer` - - `r_before_closing_wrapper` - - `r_after_closing_wrapper` - - `r_before_branding_masterplate` - - `r_after_branding_masterplate` - - `r_before_bumc_branding_logo` - - `r_after_bumc_branding_logo` - - `r_before_branding_disclaimer` - - `r_after_branding_disclaimer` - - ~~`r_before_content_banner_{position}`~~ - - ~~`r_before_content_banner`~~ - - ~~`r_after_content_banner_{position}`~~ - - ~~`r_after_content_banner`~~ + - `r_after_opening_body_tag` + - `r_before_opening_wrapper` + - `r_after_opening_wrapper` + - `r_before_opening_container_outer` + - `r_after_opening_container_outer` + - `r_before_opening_container_inner` + - `r_after_opening_container_inner` + - `r_before_masthead` + - `r_after_masthead` + - `r_before_closing_container_inner` + - `r_after_closing_container_inner` + - `r_before_closing_container_outer` + - `r_after_closing_container_outer` + - `r_before_closing_wrapper` + - `r_after_closing_wrapper` + - `r_before_branding_masterplate` + - `r_after_branding_masterplate` + - `r_before_bumc_branding_logo` + - `r_after_bumc_branding_logo` + - `r_before_branding_disclaimer` + - `r_after_branding_disclaimer` + - ~~`r_before_content_banner_{position}`~~ + - ~~`r_before_content_banner`~~ + - ~~`r_after_content_banner_{position}`~~ + - ~~`r_after_content_banner`~~ - ~~Added `r_content_banner_args` filter for modifying generated content banner arguments.~~ - ~~Added `r_content_banner_output` filter for modifying content banner output. @@ -250,11 +250,11 @@ ## 1.3.4-beta - Create new gravity forms contact forms only when necessary. - - They should be generated only when current site has contact forms using - the Contact Us plugin. - - Previous bug: gravity forms were generated for sites without contact - forms. And if the theme got activated multiple times, more gravity forms - were generated each time. + - They should be generated only when current site has contact forms using + the Contact Us plugin. + - Previous bug: gravity forms were generated for sites without contact + forms. And if the theme got activated multiple times, more gravity forms + were generated each time. ## 1.3.3-beta