Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Widget Count on footbar #124

Open
alana29s opened this issue Nov 20, 2018 · 1 comment
Open

Incorrect Widget Count on footbar #124

alana29s opened this issue Nov 20, 2018 · 1 comment
Labels
🔥 Product bug A bug which is not directly related to a custom child theme.

Comments

@alana29s
Copy link
Contributor

Responsive Version: 2x

Expected behavior:

that widget-count-# would match the number of widgets output.

Actual behavior:

widget-count-# includes widget that are not output.

Steps to reproduce:

  1. Add BU Text or BU Links widget to footbar and leave the widgets empty.
  2. Go to a page and look at inspector to see count showing more widgets than are output.

Screenshot (if this is a bug):

screen shot 2018-11-20 at 4 29 14 pm

Traced to:

<aside class="footbar <?php responsive_sidebar_classes( $footbar ); ?>" role="complementary">

function responsive_sidebar_classes( $sidebar_id ) {

See this PR that had similar issues ( individual count incorrect instead of total count ).
#96

@alana29s alana29s added the 🔥 Product bug A bug which is not directly related to a custom child theme. label Nov 20, 2018
@ashleykolodziej
Copy link
Contributor

This is related to #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Product bug A bug which is not directly related to a custom child theme.
Projects
None yet
Development

No branches or pull requests

2 participants