From 08c10eac8aea61b30ce686a0a6df7a1e1944c220 Mon Sep 17 00:00:00 2001 From: Julian Figueroa Date: Thu, 29 Feb 2024 17:58:24 -0500 Subject: [PATCH] lints --- .../bufpkg/bufmodule/bufmoduletesting/test_module_reader.go | 2 +- private/bufpkg/bufmodule/module.go | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/private/bufpkg/bufmodule/bufmoduletesting/test_module_reader.go b/private/bufpkg/bufmodule/bufmoduletesting/test_module_reader.go index 97520cf199..d9265c1d6a 100644 --- a/private/bufpkg/bufmodule/bufmoduletesting/test_module_reader.go +++ b/private/bufpkg/bufmodule/bufmoduletesting/test_module_reader.go @@ -32,7 +32,7 @@ func newTestModuleReader(moduleIdentityStringToModule map[string]bufmodule.Modul } } -func (r *testModuleReader) GetModule(ctx context.Context, modulePin bufmoduleref.ModulePin) (bufmodule.Module, error) { +func (r *testModuleReader) GetModule(_ context.Context, modulePin bufmoduleref.ModulePin) (bufmodule.Module, error) { module, ok := r.moduleIdentityStringToModule[modulePin.IdentityString()] if !ok { return nil, &fs.PathError{Op: "read", Path: modulePin.String(), Err: fs.ErrNotExist} diff --git a/private/bufpkg/bufmodule/module.go b/private/bufpkg/bufmodule/module.go index 6cb8ac242a..52771322e7 100644 --- a/private/bufpkg/bufmodule/module.go +++ b/private/bufpkg/bufmodule/module.go @@ -83,7 +83,6 @@ func newModuleForProto( } } return newModule( - ctx, readWriteBucket, allDependenciesRefs, // Since proto has no distinction between direct/transitive dependencies, we'll need to set them all as direct, otherwise the build will fail. dependencyModulePins, @@ -183,7 +182,6 @@ func newModuleForBucket( moduleIdentity = moduleConfig.ModuleIdentity } return newModule( - ctx, storage.MapReadBucket(sourceReadBucket, storage.MatchPathExt(".proto")), moduleConfig.Build.DependencyModuleReferences, // straight copy from the buf.yaml file dependencyModulePins, @@ -220,7 +218,6 @@ func newModuleForFileSet( // this should only be called by other newModule constructors func newModule( - ctx context.Context, // must only contain .proto files sourceReadBucket storage.ReadBucket, declaredDirectDependencies []bufmoduleref.ModuleReference,