Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow importing files from remote URLs #353

Open
moeffju opened this issue Sep 17, 2023 · 4 comments
Open

Feature Request: Allow importing files from remote URLs #353

moeffju opened this issue Sep 17, 2023 · 4 comments
Labels

Comments

@moeffju
Copy link
Contributor

moeffju commented Sep 17, 2023

Instead of uploading a file, it would be great if I could give a URL to download the file from.

@pajowu pajowu added enhancement New feature or request backend frontend labels Sep 17, 2023
@pajowu
Copy link
Member

pajowu commented Sep 20, 2023

This opens a whole can of worms securitywise, which I'm not sure we can tackle properly (biggest issue being CSRF). Maybe a first step would be adding an allowlist of domains as a config option, so operators of transcribee instances can allow the ones they need. For example, we probably want to allow media.ccc.de which is a relatively trusted source. Would that work for you @moeffju?

@phlmn
Copy link
Member

phlmn commented Sep 20, 2023

Why does this create CSRF issues? We could download the URL via the server and there is no need to authenticate the request IMO.

@pajowu
Copy link
Member

pajowu commented Sep 20, 2023

Ah sorry, typo: SSRF

@phlmn
Copy link
Member

phlmn commented Sep 21, 2023

I see... requesting internal locations would be bad... Is it feasible to block internal requests and request external locations without authentication? Is a TLD allowlist a sane option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants