Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] Allow ignoring errors by Error type #55

Open
pedromss opened this issue Nov 18, 2024 · 4 comments
Open

[feature-request] Allow ignoring errors by Error type #55

pedromss opened this issue Nov 18, 2024 · 4 comments

Comments

@pedromss
Copy link

pedromss commented Nov 18, 2024

I noticed that out of the box Plugsnag reports 404 Phoenix.Router.NoRouteError errors. I would like to request a feature that allows not reporting based on status code exception. I can't see a use case for wanting to report 404 NoRouteError as a bugsnag because anything can trigger a 404 NoRouteError so if someone were to spam our system with routes we don't have we'd essentially be bleeding out Bugsnag quota.

From the docs, there didn't seem to be a way around this, I only say the custom error builder, but I might have missed something.

Let me know if you're open to this and if you'd like me to take a shot at it.

@nirev
Copy link
Member

nirev commented Nov 18, 2024

Hi, @pedromss

I've since moved to other providers so not actively using Bugsnag anymore.
I do think it makes sense and would welcome a PR!

@grzuy
Copy link

grzuy commented Nov 20, 2024

I noticed that out of the box Plugsnag reports 404 errors

Does it?

Are changes introduced in #40 not working?

@pedromss
Copy link
Author

pedromss commented Nov 21, 2024

You're correct, I made a mistake in the report. Its not a 404, its a NoRouteError error raised by Phoenix. I'll update the initial description to reflect that.

@pedromss pedromss changed the title [feature-request] Allow ignoring errors by status code [feature-request] Allow ignoring errors by Error type Nov 21, 2024
@grzuy
Copy link

grzuy commented Nov 21, 2024

Hey @pedromss ,

You're correct, I made a mistake in the report. Its not a 404, its a NoRouteError error raised by Phoenix. I'll update the initial description to reflect that.

NoRouteError is a 404 per https://github.com/phoenixframework/phoenix/blob/e99f657f1cc9062fca0f2b8b79bc90659d8bd514/lib/phoenix/router.ex#L6, right?

So, I guess my question

Are changes introduced in #40 not working?

still stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants