buildarr sonarr dump-config does not output the type field for some resource types

[Callum027]

Discussed in buildarr/buildarr#195.

This is happening because the type field is not being explicitly defined on remotely fetched Indexer objects.

buildarr_sonarr/config/indexers.py:195-207

Confirmed broken for:

• Indexers
• Notification connections

[EnjoyBacon7]

This is also an issue for download clients and connections ("connect"). Sadly, I suppose this makes Buildarr unusable here.

[skwort]

I ran into this issue today. I ran my patched dump-config for my Sonarr instance and it did not output a type field for my indexer or download client settings resulting in the error message below.

pydantic.error_wrappers.ValidationError: 4 validation errors for Config
sonarr -> settings -> indexers -> definitions -> Anidex (Prowlarr)
  Discriminator 'type' is missing in value (type=value_error.discriminated_union.missing_discriminator; discriminator_key=type)
sonarr -> settings -> indexers -> definitions -> Nyaa.si (Prowlarr)
  Discriminator 'type' is missing in value (type=value_error.discriminated_union.missing_discriminator; discriminator_key=type)
sonarr -> settings -> indexers -> definitions -> TheRARBG (Prowlarr)
  Discriminator 'type' is missing in value (type=value_error.discriminated_union.missing_discriminator; discriminator_key=type)
sonarr -> settings -> download_clients -> definitions -> qBittorrent
  Discriminator 'type' is missing in value (type=value_error.discriminated_union.missing_discriminator; discriminator_key=type)

I was able to mitigate this for the Indexer and DownloadClient types by patching the code as follows:

diff --git a/buildarr_sonarr/config/download_clients/download_clients.py b/buildarr_sonarr/config/download_clients/download_clients.py
index 5243e51..8e72735 100644
--- a/buildarr_sonarr/config/download_clients/download_clients.py
+++ b/buildarr_sonarr/config/download_clients/download_clients.py
@@ -323,6 +323,7 @@ class DownloadClient(SonarrConfigBase):
                 cls._get_base_remote_map(tag_ids) + cls._remote_map,
                 remote_attrs,
             ),
+            type=cls._implementation_name.lower()
         )
 
     def _create_remote(
diff --git a/buildarr_sonarr/config/indexers.py b/buildarr_sonarr/config/indexers.py
index a873fa5..08e885f 100644
--- a/buildarr_sonarr/config/indexers.py
+++ b/buildarr_sonarr/config/indexers.py
@@ -204,6 +204,7 @@ class Indexer(SonarrConfigBase):
                 cls._get_base_remote_map(download_client_ids, tag_ids) + cls._remote_map,
                 remote_attrs,
             ),
+            type=cls._implementation_name.lower()
         )
 
     def _create_remote(

This ensures that the outputted yaml contains the type field. I will submit a PR.