-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IFC4X3_ADD2 - Implementers Stance on IFC-GUID #154
Comments
copied over from @AngelVelezSosa on Slack
|
Thanks @evandroAlfieri! What he said I said :) |
For specific versions and variants additional bit patterns may be invalid. Are these also things we want to check for? This may be something that needs to be augmented over time, cfr the v7 guid which was standardized not so long ago. |
I don't know that IFC needs to be concerned about the specifics, just that it is potentially a valid GUID. It isn't if the first number is 4. |
Afaik this has always been the case. For one, it is not a 22 character string, it is a 128 bit number, And the string is an encoded version of this number. Unfortunately you can write invalid string manually and its not very clearly stated in previous documentations why this is the case. all the way to IFC2x (oldest one I can find) (also currently several sample files in 4x3 documentation now have invalid guids) |
Hello,
The encoding process behind the creation of an IFC-GUID has been made more explicit in IFC4X3_ADD2 compared to prior ISO versions.
Though it might have been followed implicitly by some, it is now part of the official documentation.
In previous ISO versions, IFC2X3 and IFC4 I assume that the following rules were the basis for checking an IFC-GUID correctness:
Base 64 Encoding Character Set
"0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_$"
Starting IFC4X3_ADD2, the following rule could be added:
I wrote "could" because it brings me to the title of this topic.
I don't know if this rule should be strictly enforced or not, so let's open the discussion:
What is the implementers stance on this?
@evandroAlfieri I wrote a simple IFC4X3_ADD2 test file in which I listed all the GUID invalidity cases I could think of.
IFC4X3_ADD2_GuidTests.ifc.txt
I ran it inside the validation service and only one case appeared as invalid.
For people interested, I think it would also be a good foundation for a workshop dedicated to understand how to write custom ( / or soon to be implementers-approved) rules for the validation service.
Best Regards,
Guillaume
The text was updated successfully, but these errors were encountered: