No tags on SQS queues

[sj26]

The elastic stack creates SQS queues as part of its lifecycle handling through lifecycled:
https://github.com/buildkite/lifecycled/blob/74e330d38ba66da736591209b38fc218a15a7c8a/queue.go#L72-L78

But these queues are created without tags. Most resources created by the stack either have a tag reflecting the stack name:

elastic-ci-stack-for-aws/templates/aws-stack.yml

Lines 523 to 525 in c7b586a

	Tags:
	- Key: Name
	Value: !Ref 'AWS::StackName'

or the cost allocation tags:

elastic-ci-stack-for-aws/templates/aws-stack.yml

Lines 65 to 70 in c7b586a

	- Label:
	default: Cost Allocation Configuration
	Parameters:
	- EnableCostAllocationTags
	- CostAllocationTagName
	- CostAllocationTagValue

elastic-ci-stack-for-aws/templates/aws-stack.yml

Lines 701 to 706 in c7b586a

	Tags:
	- !If
	- UseCostAllocationTags
	- Key: !Ref CostAllocationTagName
	Value: !Ref CostAllocationTagValue
	- !Ref "AWS::NoValue"

We should propagate these to the queues created by lifecycled so that customers can track these created resources against the stack for audit and cost purposes.

There's already a relevant issue on lifecycled as well:
buildkite/lifecycled#17

[yob]

Looking at the lifecycled code, it seems to create the SQS queues to catch and handle ASG-initiated scale down terminations.

However, on master the ASG never initiates a scale down. Each instance self-terminates and reduces the ASG desired count by 1. Could we configure lifecycled to skip the SQS queue creation when we only need to monitor for spot instance termination?

[sj26]

I did a little look-see if we could remove it, and thought maybe we couldn't because of spot instances?

[yob]

I've never worked with lifecycled, but it looks like the impending spot termination notifications are implemented as a polling loop against the instance metadata:

https://github.com/buildkite/lifecycled/blob/74e330d38ba66da736591209b38fc218a15a7c8a/spot.go#L46-L80

paging @lox

[lox]

Correct, at this stage we only use lifecycled for gracefully handling spot termination notices. We can ditch all the sqs/sns lifecycle event stuff (I actually thought I had already).

[chloeruka]

Closing this as we don't have SQS resources anymore. #135 #829