Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract turn.js out of the starter repo #64

Open
pascallaliberte opened this issue Jun 28, 2022 · 1 comment
Open

Extract turn.js out of the starter repo #64

pascallaliberte opened this issue Jun 28, 2022 · 1 comment
Assignees

Comments

@pascallaliberte
Copy link
Member

See bullet-train-co/bullet_train#221

@pascallaliberte pascallaliberte self-assigned this Jun 28, 2022
This was referenced Sep 6, 2022
@domchristie
Copy link

FWIW I've released Turn on npm. (You'll still need to include the CSS.)

It also includes a basic way disabled transitions by adding data-turn="false" to the body. This might be handy when transitioning from a feature that uses transitions to one that doesn't. For example, one thing I've noticed about the Bullet Train flow is that the Dashboard doesn't transition after sign in. We could add data-turn-enter to the page with a simple fade-in animation, and also add data-turn="false" to disable transitions from that screen.

What do you reckon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants