Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returns a POSIXlt? #14

Open
mlgrm opened this issue Oct 8, 2021 · 1 comment
Open

returns a POSIXlt? #14

mlgrm opened this issue Oct 8, 2021 · 1 comment

Comments

@mlgrm
Copy link

mlgrm commented Oct 8, 2021

It looks like the timeInput() object returns a POSIXlt object even when set with a POSIXct object. Is this intentional? I ask because the listish POSIXlt object is harder to work with in data frames and tibbles than the atomic POSIXct and, in my case, resulted in a hard-to-pin-down bug. (Of course, that may just be my lack of familiarity with date-time objects...)

@burgerga
Copy link
Owner

Sorry for the late reply, my notification settings were all wrong and I didn't get notifications for new issues.
I don't keep track of how the widget was initialized, but if you want to use POSIXct just use as.POSIXct on the output of the widget, that is indeed more efficient in data frames and tibbles.

I will probably add a note about this in the documentation because it is a good point. I will leave the issue open for now, maybe in the feature I can think about it some more :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants