Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group validation should fail if group no longer exists #281

Closed
tl-adrian-bridgett opened this issue Feb 6, 2020 · 1 comment · Fixed by #282
Closed

group validation should fail if group no longer exists #281

tl-adrian-bridgett opened this issue Feb 6, 2020 · 1 comment · Fixed by #282

Comments

@tl-adrian-bridgett
Copy link

If group validation is enabled (with my fix for #125) then if the group is deleted, the user is still allowed in as the cache is not updated.

I think we should be playing very safe here and failing. This also applies for nested groups.

There is a log message:

 {"error":"GROUP_NOT_FOUND","level":"error","msg":"error updating fill cache","service":"sso-authenticator",...

Version: master with PR 275 and PR 280 applied
@Jusshersmith
Copy link
Contributor

Hey @tl-adrian-bridgett! Thanks for submitting this!

I'm working on this PR which should help here -- when the cache refreshes (based on a TTL) and it can't find a group, that group is removed from the cache.

@Jusshersmith Jusshersmith linked a pull request Feb 10, 2020 that will close this issue
fillcache: remove group from cache if it can't be found by the identity provider #282
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fillcache: remove group from cache if it can't be found by the identity provider buzzfeed/sso
2 participants
@Jusshersmith @tl-adrian-bridgett