Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ./bingo/README.md: variables.go was never supported. #141

Closed
kishaningithub opened this issue May 16, 2023 · 3 comments · Fixed by #148
Closed

Fix ./bingo/README.md: variables.go was never supported. #141

kishaningithub opened this issue May 16, 2023 · 3 comments · Fixed by #148
Labels
bug Something isn't working

Comments

@kishaningithub
Copy link

bingo version output:
v0.8

go version output:
go version go1.20.4 darwin/arm64

What happened:
variables.go file is not generated by bingo as documented in README

What you expected to happen:
variables.go should be generated

How to reproduce it (as minimally and precisely as possible):

  • Use bingo in a new project

Examples:
You can see it in this repo itself. If you look at the code below you see the README documentation generated by bingo

bingo/.bingo/README.md

Line 9 in fd11be5

* For go: Import `.bingo/variables.go` to for variable names.

but if you look at the directory the variables.go file is not present.
@aimuz
Copy link
Contributor

aimuz commented Jul 10, 2023

This does not seem to be supported

@bwplotka bwplotka added the bug Something isn't working label Aug 3, 2023
@bwplotka bwplotka changed the title variables.go file is not generated Fix ./bingo/README.md: variables.go was never supported. Aug 3, 2023
@bwplotka
Copy link
Owner

bwplotka commented Aug 3, 2023

Thanks!

Sorry, it's left our readme item, it's not supported as we didn't find a lot of use cases. Do you need this?

Let's then remove the mention of it - here: https://github.com/bwplotka/bingo/blob/main/get.go#L820

Help wanted (:

@kishaningithub
Copy link
Author

@bwplotka I was hoping that this would fix the following observation (screenshot and link below)

jeroenrinzema/psql-wire#58 (comment)
image

aimuz added a commit to aimuz/bingo that referenced this issue Nov 30, 2023
@aimuz
Remove unsupported variables.go reference from README
8e86d4b 
The reference to `variables.go` in the README was removed because it is
not supported. There were not enough use cases to justify its presence.

Fixes bwplotka#141
@aimuz aimuz mentioned this issue Nov 30, 2023
Merged
aimuz added a commit to aimuz/bingo that referenced this issue Nov 30, 2023
@aimuz
Remove unsupported variables.go reference from README
80a63a1 
The reference to `variables.go` in the README was removed because it is
not supported. There were not enough use cases to justify its presence.

Fixes bwplotka#141
bwplotka pushed a commit that referenced this issue Dec 18, 2023
@aimuz
Remove unsupported variables.go reference from README (#148)
16ea027 
The reference to `variables.go` in the README was removed because it is
not supported. There were not enough use cases to justify its presence.

Fixes #141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unsupported variables.go reference from README aimuz/bingo
3 participants
@kishaningithub @bwplotka @aimuz