Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify bench job summary #1018

Open
xcoulon opened this issue May 10, 2022 · 0 comments
Open

Simplify bench job summary #1018

xcoulon opened this issue May 10, 2022 · 0 comments
Assignees
@xcoulon
Labels
area/bench type/refactor
Milestone
backlog

Comments

@xcoulon
Copy link
Member

xcoulon commented May 10, 2022

Use the new $GITHUB_STEP_SUMMARYenvironment variable to provide a summary of the bench.
Also, remove the step which publishes the summary using marocchino/sticky-pull-request-comment@v2 and use a regular pull_request trigger instead of pull_request_target

See https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/
@xcoulon xcoulon added this to the v0.8.0 milestone May 10, 2022
@xcoulon xcoulon self-assigned this May 10, 2022
@xcoulon xcoulon modified the milestones: v0.8.0, backlog May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/bench type/refactor
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
1 participant
@xcoulon