From 7f8f06ac631a5fa414e762fab79e162f31f41935 Mon Sep 17 00:00:00 2001 From: Rob Knop Date: Wed, 17 Jul 2024 08:54:32 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: whohensee <106775295+whohensee@users.noreply.github.com> --- conductor/updater.py | 2 +- hacks/rknop/README.md | 2 +- models/knownexposure.py | 2 +- tests/fixtures/decam.py | 1 - 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/conductor/updater.py b/conductor/updater.py index b288dd32..86c44b2e 100644 --- a/conductor/updater.py +++ b/conductor/updater.py @@ -9,7 +9,7 @@ import json import multiprocessing -# Have to manaully import any instrument modules +# Have to manually import any instrument modules # we want to be able to find. (Otherwise, they # won't be found when models.instrument is # initialized.) diff --git a/hacks/rknop/README.md b/hacks/rknop/README.md index 181f51fc..395c859a 100644 --- a/hacks/rknop/README.md +++ b/hacks/rknop/README.md @@ -74,7 +74,7 @@ db: * Get a SSL cert for `ls4-conductor-rknop-dev.lbl.gov` * Put the b64 encoded stuff in `conductor-cert.yaml` and apply it * Uncomment the stuff in `conductor.yaml` and apply it -* Create user rknop manually in the conductor database (until such a time as the conductor has an actual interfrace for this). +* Create user rknop manually in the conductor database (until such a time as the conductor has an actual interface for this). * (Once the ls4-conductor-rknop-dev.lbl.gov address is available.) Use the web interface to ls4-conductor-rknop-dev.lbl.gov to set rknop's password on the conductor. (Consider saving the database barf for the public and private keys to avoid having to do this upon database recreation.) ### Set up the archive diff --git a/models/knownexposure.py b/models/knownexposure.py index c4d5727c..8770b6b2 100644 --- a/models/knownexposure.py +++ b/models/knownexposure.py @@ -16,7 +16,7 @@ class KnownExposure(Base, AutoIDMixin): Most fields are nullable because we can't be sure a priori how much information we'll be able to get about known exposures before we download them and start processing them -- they may only be a list - of filenames, for instance. exposuresurce must be known (because + of filenames, for instance. exposuresource must be known (because that's where they come from), and we're assuming that the instrument will be known. identifier required, and is some sort of unique identifier that specifies this exposure; it's interpretation is diff --git a/tests/fixtures/decam.py b/tests/fixtures/decam.py index 3b9eea65..8cca778a 100644 --- a/tests/fixtures/decam.py +++ b/tests/fixtures/decam.py @@ -189,7 +189,6 @@ def decam_filename(download_url, data_dir, decam_exposure_name, decam_cache_dir) cache. """ - # base_name = 'c4d_221104_074232_ori.fits.fz' base_name = decam_exposure_name filename = os.path.join(data_dir, base_name) os.makedirs(os.path.dirname(filename), exist_ok=True)