Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessing parameters #147

Closed
guynir42 opened this issue Dec 7, 2023 · 4 comments
Closed

Preprocessing parameters #147

guynir42 opened this issue Dec 7, 2023 · 4 comments
Assignees

Comments

@guynir42
Copy link
Member

guynir42 commented Dec 7, 2023

Right now some preprocessing parameters are loaded from the instrument, and then overriden by kwargs to the run() function.

I think it is very unlikely that we will run multiple instruments' images using the same config file, so it would be simpler to just put all the parameters (e.g., which preprocessing steps need to be done) into the config, load them as critical parameters, and then have that be the only point of configuration for the preprocessing.

@guynir42
Copy link
Member Author

guynir42 commented Jan 1, 2024

Related to #104 and #173

@guynir42
Copy link
Member Author

The way it works right now makes it impossible to figure out the provenances before actually running the preprocessing. This needs to fixed. I am putting in a hack that assumes we are using all the preprocessing steps but it needs to go into the parameters of the preprocessor object.

@guynir42
Copy link
Member Author

guynir42 commented Jun 6, 2024

Should also have a skip for filters parameter that lets you do stuff like "for g filter don't use defringe"

@guynir42
Copy link
Member Author

Addressed by #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants