Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to publish should fail the task #18

Open
pimterry opened this issue Mar 17, 2016 · 0 comments · Fixed by microsoft/accessibility-insights-web#2058
Open

Failing to publish should fail the task #18

pimterry opened this issue Mar 17, 2016 · 0 comments · Fixed by microsoft/accessibility-insights-web#2058

Comments

@pimterry
Copy link

Currently failure at the publish step (getting to publishItem but getting an error response from the webstore) doesn't actually fail the task. I think it pretty unambiguously should. The issue is here: https://github.com/c301/grunt-webstore-upload/blob/master/tasks/webstore_upload.js#L344. This needs to inform Grunt of the failure.

Should be an easy fix, but I'm a bit busy atm. Might get time to take a look at fixing this myself maybe in future, but not sure, so just filing it here for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant