From 59eb6d3cf430c6737f14d567f7e5df6cc1ea6f82 Mon Sep 17 00:00:00 2001
From: Carine Dengler <git@carine-dengler.de>
Date: Tue, 12 Dec 2023 18:03:16 +0100
Subject: [PATCH 1/6] test: add evoting API mock

---
 web/frontend/tests/mocks.ts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/web/frontend/tests/mocks.ts b/web/frontend/tests/mocks.ts
index 675f48a72..21a45d21d 100644
--- a/web/frontend/tests/mocks.ts
+++ b/web/frontend/tests/mocks.ts
@@ -50,3 +50,25 @@ export async function mockProxy(page: any) {
     });
   });
 }
+
+export async function mockEvoting(page: any, numberForms: number) {
+  await page.route(`${process.env.DELA_PROXY_URL}/evoting/forms`, async (route) => {
+    if route.request().method() === 'OPTIONS' {
+      await route.fulfill({
+        status: 200,
+        headers: {
+          'Access-Control-Allow-Headers': '*',
+          'Access-Control-Allow-Origin': '*',
+        }
+      });
+    }
+    else {
+      await page.routeFromHAR(
+        `./tests/hars/forms/${numberForms}.har`,
+        {
+          url: `${process.env.DELA_PROXY_URL}/evoting/forms`,
+          update: UPDATE
+        });
+    }
+  });
+}

From 055c2f3aa561459d0d51405133adf98223c92e8a Mon Sep 17 00:00:00 2001
From: Carine Dengler <git@carine-dengler.de>
Date: Wed, 13 Dec 2023 10:35:25 +0100
Subject: [PATCH 2/6] test: add /form/index route tests for navbar/footer

---
 web/frontend/src/layout/NavBar.tsx   |  2 +-
 web/frontend/tests/formIndex.spec.ts | 23 +++++++++++++++++++++++
 web/frontend/tests/shared.ts         |  8 ++++++--
 3 files changed, 30 insertions(+), 3 deletions(-)
 create mode 100644 web/frontend/tests/formIndex.spec.ts

diff --git a/web/frontend/src/layout/NavBar.tsx b/web/frontend/src/layout/NavBar.tsx
index fc2721824..0ced61ff2 100644
--- a/web/frontend/src/layout/NavBar.tsx
+++ b/web/frontend/src/layout/NavBar.tsx
@@ -240,7 +240,7 @@ const NavBar: FC = () => {
   };
 
   return (
-    <nav className="w-full border-b">
+    <nav data-testid="navBar" className="w-full border-b">
       <div className="max-w-7xl mx-auto px-2 md:px-6 lg:px-8">
         <div className="relative flex items-center justify-between h-16">
           <MobileMenu authCtx={authCtx} handleLogout={handleLogout} fctx={fctx} t={t} />
diff --git a/web/frontend/tests/formIndex.spec.ts b/web/frontend/tests/formIndex.spec.ts
new file mode 100644
index 000000000..18302b552
--- /dev/null
+++ b/web/frontend/tests/formIndex.spec.ts
@@ -0,0 +1,23 @@
+import { test } from '@playwright/test';
+import { assertHasFooter, assertHasNavBar, initI18n, setUp } from './shared';
+import { UPDATE, mockPersonalInfo } from './mocks';
+
+initI18n();
+
+test.beforeEach(async ({ page }) => {
+  if (UPDATE === true) {
+    return;
+  }
+  await mockPersonalInfo(page);
+  await setUp(page, '/form/index');
+});
+
+test('Assert navigation bar is present', async ({ page }) => {
+  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
+  await assertHasNavBar(page);
+});
+
+test('Assert footer is present', async ({ page }) => {
+  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
+  await assertHasFooter(page);
+});
diff --git a/web/frontend/tests/shared.ts b/web/frontend/tests/shared.ts
index bdd1ad6b2..7f549820c 100644
--- a/web/frontend/tests/shared.ts
+++ b/web/frontend/tests/shared.ts
@@ -47,6 +47,10 @@ export async function assertOnlyVisibleToAdmin(page: any, locator: any) {
   await expect(locator).toBeVisible(); // assert is visible to admin user
 }
 
-export async function getFooter(page: any) {
-  return page.getByTestId('footer');
+export async function assertHasNavBar(page: any) {
+  await expect(page.getByTestId('navBar')).toBeVisible();
+}
+
+export async function assertHasFooter(page: any) {
+  await expect(page.getByTestId('footer')).toBeVisible();
 }

From be17e6472198a819dcbcb69dca004014853e305d Mon Sep 17 00:00:00 2001
From: Carine Dengler <git@carine-dengler.de>
Date: Wed, 13 Dec 2023 15:28:50 +0100
Subject: [PATCH 3/6] fix: fix misleading page numbering and add pagination
 tests

---
 .../src/pages/form/components/FormTable.tsx   |   9 +-
 web/frontend/tests/formIndex.spec.ts          |  49 +++++++-
 web/frontend/tests/json/formList.json         | 114 ++++++++++++++++++
 web/frontend/tests/mocks.ts                   |  26 ++--
 4 files changed, 182 insertions(+), 16 deletions(-)
 create mode 100644 web/frontend/tests/json/formList.json

diff --git a/web/frontend/src/pages/form/components/FormTable.tsx b/web/frontend/src/pages/form/components/FormTable.tsx
index 78b40d427..9fc282163 100644
--- a/web/frontend/src/pages/form/components/FormTable.tsx
+++ b/web/frontend/src/pages/form/components/FormTable.tsx
@@ -27,6 +27,8 @@ const FormTable: FC<FormTableProps> = ({ forms, pageIndex, setPageIndex }) => {
 
     return [];
   };
+  // 1st page w/ empty list is always shown
+  const numPages = partitionArray(forms, FORM_PER_PAGE).length || 1;
 
   useEffect(() => {
     if (forms !== null) {
@@ -73,12 +75,13 @@ const FormTable: FC<FormTableProps> = ({ forms, pageIndex, setPageIndex }) => {
           </tbody>
         </table>
         <nav
+          data-testid="navPagination"
           className="bg-white px-4 py-3 flex items-center justify-between border-t border-gray-200 sm:px-6"
           aria-label="Pagination">
-          <div className="hidden sm:block text-sm text-gray-700">
+          <div data-testid="navPaginationMessage" className="hidden sm:block text-sm text-gray-700">
             {t('showingNOverMOfXResults', {
               n: pageIndex + 1,
-              m: partitionArray(forms, FORM_PER_PAGE).length,
+              m: numPages,
               x: `${forms !== null ? forms.length : 0}`,
             })}
           </div>
@@ -90,7 +93,7 @@ const FormTable: FC<FormTableProps> = ({ forms, pageIndex, setPageIndex }) => {
               {t('previous')}
             </button>
             <button
-              disabled={partitionArray(forms, FORM_PER_PAGE).length <= pageIndex + 1}
+              disabled={numPages <= pageIndex + 1}
               onClick={handleNext}
               className="ml-3 relative inline-flex items-center px-4 py-2 border border-gray-300 text-sm font-medium rounded-md text-gray-700 bg-white hover:bg-gray-50">
               {t('next')}
diff --git a/web/frontend/tests/formIndex.spec.ts b/web/frontend/tests/formIndex.spec.ts
index 18302b552..04b1656e0 100644
--- a/web/frontend/tests/formIndex.spec.ts
+++ b/web/frontend/tests/formIndex.spec.ts
@@ -1,6 +1,7 @@
-import { test } from '@playwright/test';
+import { expect, test } from '@playwright/test';
+import { default as i18n } from 'i18next';
 import { assertHasFooter, assertHasNavBar, initI18n, setUp } from './shared';
-import { UPDATE, mockPersonalInfo } from './mocks';
+import { UPDATE, mockPersonalInfo, mockEvoting } from './mocks';
 
 initI18n();
 
@@ -8,10 +9,14 @@ test.beforeEach(async ({ page }) => {
   if (UPDATE === true) {
     return;
   }
+  // mock empty list per default
+  await mockEvoting(page);
   await mockPersonalInfo(page);
   await setUp(page, '/form/index');
 });
 
+// main elements
+
 test('Assert navigation bar is present', async ({ page }) => {
   test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   await assertHasNavBar(page);
@@ -21,3 +26,43 @@ test('Assert footer is present', async ({ page }) => {
   test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   await assertHasFooter(page);
 });
+
+// pagination bar
+
+test('Assert pagination bar is present', async ({ page }) => {
+  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
+  await expect(page.getByTestId('navPagination')).toBeVisible();
+  await expect(page.getByRole('button', { name: i18n.t('previous') })).toBeVisible();
+  await expect(page.getByRole('button', { name: i18n.t('next') })).toBeVisible();
+});
+
+test('Assert pagination works correctly for empty list', async ({ page }) => {
+  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
+  await expect(page.getByTestId('navPaginationMessage')).toHaveText(i18n.t('showingNOverMOfXResults', { n: 1, m: 1, x: 0 }));
+  for (let key of ['next', 'previous']) {
+    await expect(page.getByRole('button', { name: i18n.t(key) })).toBeDisabled();
+  }
+});
+
+test('Assert pagination works correctly for non-empty list', async ({ page }) => {
+  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
+  // mock non-empty list w/ 11 elements i.e. 2 pages
+  await mockEvoting(page, false);
+  await page.reload();
+  const next = await page.getByRole('button', { name: i18n.t('next') });
+  const previous = await page.getByRole('button', { name: i18n.t('previous') });
+  // 1st page
+  await expect(page.getByTestId('navPaginationMessage')).toHaveText(i18n.t('showingNOverMOfXResults', { n: 1, m: 2, x: 11 }));
+  await expect(previous).toBeDisabled();
+  await expect(next).toBeEnabled();
+  await next.click();
+  // 2nd page
+  await expect(page.getByTestId('navPaginationMessage')).toHaveText(i18n.t('showingNOverMOfXResults', { n: 2, m: 2, x: 11 }));
+  await expect(next).toBeDisabled();
+  await expect(previous).toBeEnabled();
+  await previous.click();
+  // back to 1st page
+  await expect(page.getByTestId('navPaginationMessage')).toHaveText(i18n.t('showingNOverMOfXResults', { n: 1, m: 2, x: 11 }));
+  await expect(previous).toBeDisabled();
+  await expect(next).toBeEnabled();
+});
diff --git a/web/frontend/tests/json/formList.json b/web/frontend/tests/json/formList.json
new file mode 100644
index 000000000..5c237fb5c
--- /dev/null
+++ b/web/frontend/tests/json/formList.json
@@ -0,0 +1,114 @@
+{
+  "Forms": [
+    {
+      "FormID": "f1700a27cef992db7eac71f006a1566369d21e4b76933f43e84a2ae23195e678",
+      "Title": {
+        "En": "Colours",
+        "Fr": "",
+        "De": ""
+      },
+      "Status": 5,
+      "Pubkey": "d27836cec530a5e4d255ab704547438b8eede9af7ba78833a7da907064613a71"
+    },
+    {
+      "FormID": "6783449fb12c481d8e06a27cfdfb7971ad12dcff2083bfe90be35f44fb572d67",
+      "Title": {
+        "En": "Foo",
+        "Fr": "Toto",
+        "De": ""
+      },
+      "Status": 3,
+      "Pubkey": "ff83fcc6018685fc3b90f5029eec0f948ff57e220b87c538bdb1a5e17f5c549d"
+    },
+    {
+      "FormID": "ed26713245824d44ee46ec90507ef521962f2313706934cdfe76ff1823738109",
+      "Title": {
+        "En": "Christmas Tree",
+        "Fr": "Sapin de Noël",
+        "De": "Weihnachtsbaum"
+      },
+      "Status": 2,
+      "Pubkey": "3964e8383919eafdeb998d6a694d9a8a74a5438d9d00868fdabcb07fa1a1be28"
+    },
+    {
+      "FormID": "fdf8bfb702e8883e330a2b303b24212b6fc16df5a53a097998b77ba74632dc72",
+      "Title": {
+        "En": "Line 6",
+        "Fr": "",
+        "De": ""
+      },
+      "Status": 1,
+      "Pubkey": "725502be5772ec458f061abeaeb50f45c0f5c07abd530bfc95334d80f3184fbc"
+    },
+    {
+      "FormID": "4440182e69ef1fbbcdd5cd870e46a59a09fd32a89b8353bab677fe84a5c2f073",
+      "Title": {
+        "En": "RER A",
+        "Fr": "",
+        "De": ""
+      },
+      "Status": 0,
+      "Pubkey": ""
+    },
+    {
+      "FormID": "9f50ad723805a6419ba1a9f83dd0aa582f3e13b94f14727cd0c8c01744e0dba2",
+      "Title": {
+        "En": "Languages",
+        "Fr": "",
+        "De": ""
+      },
+      "Status": 0,
+      "Pubkey": ""
+    },
+    {
+      "FormID": "1269a8507dc316a9ec983ede527705078bfef2b151a49f7ffae6e903ef1bb38f",
+      "Title": {
+        "En": "Seasons",
+        "Fr": "",
+        "De": ""
+      },
+      "Status": 0,
+      "Pubkey": ""
+    },
+    {
+      "FormID": "576be424ee2f37699e74f3752b8912c8cdbfa735a939e1c238863d5d2012bb26",
+      "Title": {
+        "En": "Pets",
+        "Fr": "",
+        "De": ""
+      },
+      "Status": 0,
+      "Pubkey": ""
+    },
+    {
+      "FormID": "06861f854608924f42c99f2c78b22263ea79a9b27d6c616de8f73a8cb7d09152",
+      "Title": {
+        "En": "Weather",
+        "Fr": "",
+        "De": ""
+      },
+      "Status": 0,
+      "Pubkey": ""
+    },
+    {
+      "FormID": "f17100c712db07ec81923c33394ff2d5e56146135ce908754ce610b898d9ba1a",
+      "Title": {
+        "En": "Currency",
+        "Fr": "",
+        "De": ""
+      },
+      "Status": 0,
+      "Pubkey": ""
+    },
+    {
+      "FormID": "a3776492297f71c4c0c75f0fd21d3d25a90ea52a60a660f4e2cb5cc3026bd396",
+      "Title": {
+        "En": "Fruits",
+        "Fr": "",
+        "De": ""
+      },
+      "Status": 0,
+      "Pubkey": ""
+    }
+  ]
+}
diff --git a/web/frontend/tests/mocks.ts b/web/frontend/tests/mocks.ts
index 21a45d21d..b6acb1931 100644
--- a/web/frontend/tests/mocks.ts
+++ b/web/frontend/tests/mocks.ts
@@ -51,24 +51,28 @@ export async function mockProxy(page: any) {
   });
 }
 
-export async function mockEvoting(page: any, numberForms: number) {
+export async function mockEvoting(page: any, empty: boolean = true) {
+  // clear current mock
+  await page.unroute(`${process.env.DELA_PROXY_URL}/evoting/forms`);
   await page.route(`${process.env.DELA_PROXY_URL}/evoting/forms`, async (route) => {
-    if route.request().method() === 'OPTIONS' {
+    if (route.request().method() === 'OPTIONS') {
       await route.fulfill({
         status: 200,
         headers: {
           'Access-Control-Allow-Headers': '*',
           'Access-Control-Allow-Origin': '*',
-        }
+        },
+      });
+    } else if (empty) {
+      await route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: '{"Forms": []}',
+      });
+    } else {
+      await route.fulfill({
+        path: './tests/json/formList.json',
       });
-    }
-    else {
-      await page.routeFromHAR(
-        `./tests/hars/forms/${numberForms}.har`,
-        {
-          url: `${process.env.DELA_PROXY_URL}/evoting/forms`,
-          update: UPDATE
-        });
     }
   });
 }

From 628cf71c4bbdf7ce32c00a473991565adae8552c Mon Sep 17 00:00:00 2001
From: Carine Dengler <git@carine-dengler.de>
Date: Thu, 14 Dec 2023 15:27:41 +0100
Subject: [PATCH 4/6] refactor: simplify mocking by removing reliance on HAR
 files

---
 web/frontend/README.md                        | 10 ---
 web/frontend/tests/footer.spec.ts             |  7 +--
 web/frontend/tests/formIndex.spec.ts          | 10 +--
 .../tests/hars/123456/get_dev_login.har       | 14 -----
 .../tests/hars/123456/personal_info.har       | 61 -------------------
 .../tests/hars/789012/get_dev_login.har       | 14 -----
 .../tests/hars/789012/personal_info.har       | 61 -------------------
 ...2ff4fc1fb163717539fb04aec420feeb11e5a.html |  1 -
 .../tests/hars/anonymous/personal_info.har    | 60 ------------------
 .../personal_info/123456.json}                |  0
 .../personal_info/789012.json}                |  0
 web/frontend/tests/mocks.ts                   | 21 ++++---
 web/frontend/tests/navbar.spec.ts             | 35 +----------
 13 files changed, 14 insertions(+), 280 deletions(-)
 delete mode 100644 web/frontend/tests/hars/123456/get_dev_login.har
 delete mode 100644 web/frontend/tests/hars/123456/personal_info.har
 delete mode 100644 web/frontend/tests/hars/789012/get_dev_login.har
 delete mode 100644 web/frontend/tests/hars/789012/personal_info.har
 delete mode 100644 web/frontend/tests/hars/anonymous/9fd2ff4fc1fb163717539fb04aec420feeb11e5a.html
 delete mode 100644 web/frontend/tests/hars/anonymous/personal_info.har
 rename web/frontend/tests/{hars/123456/a03037964db4d746517f562ccb09b049db7f7a12.json => json/personal_info/123456.json} (100%)
 rename web/frontend/tests/{hars/789012/5f05240cb33cb9e581ea0ce24c4e728a04e2a5d1.json => json/personal_info/789012.json} (100%)

diff --git a/web/frontend/README.md b/web/frontend/README.md
index 6625e1319..1a8a970d0 100644
--- a/web/frontend/README.md
+++ b/web/frontend/README.md
@@ -40,13 +40,3 @@ npx playwright test --ui
 ```
 
 this will open an user interface where you can interactively run and evaluate tests.
-
-## Update HAR files
-
-To update the HAR files, you need to make sure
-
-* that a complete D-Voting setup is running, as the API will be called for real, and
-* the `REACT_APP_SCIPER_ADMIN` of the D-Voting instance value is set to `123456` (i.e. the `SCIPER_ADMIN` value in the mocks).
-
-You then change the `UPDATE = false` value in `tests/mocks.ts` to `UPDATE = true` and execute
-the tests as usual. The tests that update the mocks will be run and the other tests will be skipped.
diff --git a/web/frontend/tests/footer.spec.ts b/web/frontend/tests/footer.spec.ts
index 9b3d7771a..b1f0fec80 100644
--- a/web/frontend/tests/footer.spec.ts
+++ b/web/frontend/tests/footer.spec.ts
@@ -1,20 +1,16 @@
 import { expect, test } from '@playwright/test';
 import { default as i18n } from 'i18next';
 import { initI18n, setUp } from './shared';
-import { UPDATE, mockPersonalInfo } from './mocks';
+import { mockPersonalInfo } from './mocks';
 
 initI18n();
 
 test.beforeEach(async ({ page }) => {
-  if (UPDATE === true) {
-    return;
-  }
   await mockPersonalInfo(page);
   await setUp(page, '/about');
 });
 
 test('Assert copyright notice is visible', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   const footerCopyright = await page.getByTestId('footerCopyright');
   await expect(footerCopyright).toBeVisible();
   await expect(footerCopyright).toHaveText(
@@ -23,7 +19,6 @@ test('Assert copyright notice is visible', async ({ page }) => {
 });
 
 test('Assert version information is visible', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   const footerVersion = await page.getByTestId('footerVersion');
   await expect(footerVersion).toBeVisible();
   await expect(footerVersion).toHaveText(
diff --git a/web/frontend/tests/formIndex.spec.ts b/web/frontend/tests/formIndex.spec.ts
index 04b1656e0..e16f184f8 100644
--- a/web/frontend/tests/formIndex.spec.ts
+++ b/web/frontend/tests/formIndex.spec.ts
@@ -1,14 +1,11 @@
 import { expect, test } from '@playwright/test';
 import { default as i18n } from 'i18next';
 import { assertHasFooter, assertHasNavBar, initI18n, setUp } from './shared';
-import { UPDATE, mockPersonalInfo, mockEvoting } from './mocks';
+import { mockPersonalInfo, mockEvoting } from './mocks';
 
 initI18n();
 
 test.beforeEach(async ({ page }) => {
-  if (UPDATE === true) {
-    return;
-  }
   // mock empty list per default
   await mockEvoting(page);
   await mockPersonalInfo(page);
@@ -18,26 +15,22 @@ test.beforeEach(async ({ page }) => {
 // main elements
 
 test('Assert navigation bar is present', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   await assertHasNavBar(page);
 });
 
 test('Assert footer is present', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   await assertHasFooter(page);
 });
 
 // pagination bar
 
 test('Assert pagination bar is present', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   await expect(page.getByTestId('navPagination')).toBeVisible();
   await expect(page.getByRole('button', { name: i18n.t('previous') })).toBeVisible();
   await expect(page.getByRole('button', { name: i18n.t('next') })).toBeVisible();
 });
 
 test('Assert pagination works correctly for empty list', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   await expect(page.getByTestId('navPaginationMessage')).toHaveText(i18n.t('showingNOverMOfXResults', { n: 1, m: 1, x: 0 }));
   for (let key of ['next', 'previous']) {
     await expect(page.getByRole('button', { name: i18n.t(key) })).toBeDisabled();
@@ -45,7 +38,6 @@ test('Assert pagination works correctly for empty list', async ({ page }) => {
 });
 
 test('Assert pagination works correctly for non-empty list', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   // mock non-empty list w/ 11 elements i.e. 2 pages
   await mockEvoting(page, false);
   await page.reload();
diff --git a/web/frontend/tests/hars/123456/get_dev_login.har b/web/frontend/tests/hars/123456/get_dev_login.har
deleted file mode 100644
index 3b9cb5b4c..000000000
--- a/web/frontend/tests/hars/123456/get_dev_login.har
+++ /dev/null
@@ -1,14 +0,0 @@
-{
-  "log": {
-    "version": "1.2",
-    "creator": {
-      "name": "Playwright",
-      "version": "1.40.1"
-    },
-    "browser": {
-      "name": "chromium",
-      "version": "120.0.6099.28"
-    },
-    "entries": []
-  }
-}
\ No newline at end of file
diff --git a/web/frontend/tests/hars/123456/personal_info.har b/web/frontend/tests/hars/123456/personal_info.har
deleted file mode 100644
index 1482d5dda..000000000
--- a/web/frontend/tests/hars/123456/personal_info.har
+++ /dev/null
@@ -1,61 +0,0 @@
-{
-  "log": {
-    "version": "1.2",
-    "creator": {
-      "name": "Playwright",
-      "version": "1.40.1"
-    },
-    "browser": {
-      "name": "chromium",
-      "version": "120.0.6099.28"
-    },
-    "entries": [
-      {
-        "startedDateTime": "2023-12-07T15:16:05.427Z",
-        "time": 63.36,
-        "request": {
-          "method": "GET",
-          "url": "http://127.0.0.1:3000/api/personal_info",
-          "httpVersion": "HTTP/1.1",
-          "cookies": [],
-          "headers": [
-            { "name": "Accept", "value": "*/*" },
-            { "name": "Accept-Language", "value": "en-US" },
-            { "name": "Cookie", "value": "connect.sid=s%3AxeUPf49ZYc9AUrUtzig9-O4g0Z_RVtVV.ChZVAx%2FL%2BIzfgIlkxzUxTLVduImdZIp68OdvODtveTU" },
-            { "name": "Referer", "value": "http://127.0.0.1:3000/about" },
-            { "name": "User-Agent", "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.6099.28 Safari/537.36" }
-          ],
-          "queryString": [],
-          "headersSize": -1,
-          "bodySize": -1
-        },
-        "response": {
-          "status": 200,
-          "statusText": "OK",
-          "httpVersion": "HTTP/1.1",
-          "cookies": [],
-          "headers": [
-            { "name": "access-control-allow-origin", "value": "*" },
-            { "name": "connection", "value": "keep-alive" },
-            { "name": "content-length", "value": "184" },
-            { "name": "content-type", "value": "application/json; charset=utf-8" },
-            { "name": "date", "value": "Thu, 07 Dec 2023 15:16:05 GMT" },
-            { "name": "etag", "value": "W/\"b8-oDA3lk2010ZRf1YsywmwSdt/ehI\"" },
-            { "name": "keep-alive", "value": "timeout=5" },
-            { "name": "x-powered-by", "value": "Express" }
-          ],
-          "content": {
-            "size": -1,
-            "mimeType": "application/json; charset=utf-8",
-            "_file": "a03037964db4d746517f562ccb09b049db7f7a12.json"
-          },
-          "headersSize": -1,
-          "bodySize": -1,
-          "redirectURL": ""
-        },
-        "cache": {},
-        "timings": { "send": -1, "wait": -1, "receive": 63.36 }
-      }
-    ]
-  }
-}
\ No newline at end of file
diff --git a/web/frontend/tests/hars/789012/get_dev_login.har b/web/frontend/tests/hars/789012/get_dev_login.har
deleted file mode 100644
index 3b9cb5b4c..000000000
--- a/web/frontend/tests/hars/789012/get_dev_login.har
+++ /dev/null
@@ -1,14 +0,0 @@
-{
-  "log": {
-    "version": "1.2",
-    "creator": {
-      "name": "Playwright",
-      "version": "1.40.1"
-    },
-    "browser": {
-      "name": "chromium",
-      "version": "120.0.6099.28"
-    },
-    "entries": []
-  }
-}
\ No newline at end of file
diff --git a/web/frontend/tests/hars/789012/personal_info.har b/web/frontend/tests/hars/789012/personal_info.har
deleted file mode 100644
index 2f68ed6a7..000000000
--- a/web/frontend/tests/hars/789012/personal_info.har
+++ /dev/null
@@ -1,61 +0,0 @@
-{
-  "log": {
-    "version": "1.2",
-    "creator": {
-      "name": "Playwright",
-      "version": "1.40.1"
-    },
-    "browser": {
-      "name": "chromium",
-      "version": "120.0.6099.28"
-    },
-    "entries": [
-      {
-        "startedDateTime": "2023-12-07T15:14:39.129Z",
-        "time": 56.608,
-        "request": {
-          "method": "GET",
-          "url": "http://127.0.0.1:3000/api/personal_info",
-          "httpVersion": "HTTP/1.1",
-          "cookies": [],
-          "headers": [
-            { "name": "Accept", "value": "*/*" },
-            { "name": "Accept-Language", "value": "en-US" },
-            { "name": "Cookie", "value": "connect.sid=s%3AAN1F283daySUs-3ytVagTfigWaedTgqO.iahChcGgJKx0khpkcm1jBBrQ89QsRN5cW9tOWnIgKgs" },
-            { "name": "Referer", "value": "http://127.0.0.1:3000/about" },
-            { "name": "User-Agent", "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.6099.28 Safari/537.36" }
-          ],
-          "queryString": [],
-          "headersSize": -1,
-          "bodySize": -1
-        },
-        "response": {
-          "status": 200,
-          "statusText": "OK",
-          "httpVersion": "HTTP/1.1",
-          "cookies": [],
-          "headers": [
-            { "name": "access-control-allow-origin", "value": "*" },
-            { "name": "connection", "value": "keep-alive" },
-            { "name": "content-length", "value": "97" },
-            { "name": "content-type", "value": "application/json; charset=utf-8" },
-            { "name": "date", "value": "Thu, 07 Dec 2023 15:14:39 GMT" },
-            { "name": "etag", "value": "W/\"61-XwUkDLM8ueWB6gziTE5yigTipdE\"" },
-            { "name": "keep-alive", "value": "timeout=5" },
-            { "name": "x-powered-by", "value": "Express" }
-          ],
-          "content": {
-            "size": -1,
-            "mimeType": "application/json; charset=utf-8",
-            "_file": "5f05240cb33cb9e581ea0ce24c4e728a04e2a5d1.json"
-          },
-          "headersSize": -1,
-          "bodySize": -1,
-          "redirectURL": ""
-        },
-        "cache": {},
-        "timings": { "send": -1, "wait": -1, "receive": 56.608 }
-      }
-    ]
-  }
-}
\ No newline at end of file
diff --git a/web/frontend/tests/hars/anonymous/9fd2ff4fc1fb163717539fb04aec420feeb11e5a.html b/web/frontend/tests/hars/anonymous/9fd2ff4fc1fb163717539fb04aec420feeb11e5a.html
deleted file mode 100644
index e2c1c215e..000000000
--- a/web/frontend/tests/hars/anonymous/9fd2ff4fc1fb163717539fb04aec420feeb11e5a.html
+++ /dev/null
@@ -1 +0,0 @@
-Unauthenticated
\ No newline at end of file
diff --git a/web/frontend/tests/hars/anonymous/personal_info.har b/web/frontend/tests/hars/anonymous/personal_info.har
deleted file mode 100644
index 91474fd6a..000000000
--- a/web/frontend/tests/hars/anonymous/personal_info.har
+++ /dev/null
@@ -1,60 +0,0 @@
-{
-  "log": {
-    "version": "1.2",
-    "creator": {
-      "name": "Playwright",
-      "version": "1.40.1"
-    },
-    "browser": {
-      "name": "chromium",
-      "version": "120.0.6099.28"
-    },
-    "entries": [
-      {
-        "startedDateTime": "2023-12-07T15:11:00.609Z",
-        "time": 50.718,
-        "request": {
-          "method": "GET",
-          "url": "http://127.0.0.1:3000/api/personal_info",
-          "httpVersion": "HTTP/1.1",
-          "cookies": [],
-          "headers": [
-            { "name": "Accept", "value": "*/*" },
-            { "name": "Accept-Language", "value": "en-US" },
-            { "name": "Referer", "value": "http://127.0.0.1:3000/about" },
-            { "name": "User-Agent", "value": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.6099.28 Safari/537.36" }
-          ],
-          "queryString": [],
-          "headersSize": -1,
-          "bodySize": -1
-        },
-        "response": {
-          "status": 401,
-          "statusText": "Unauthorized",
-          "httpVersion": "HTTP/1.1",
-          "cookies": [],
-          "headers": [
-            { "name": "connection", "value": "keep-alive" },
-            { "name": "content-length", "value": "15" },
-            { "name": "content-type", "value": "text/html; charset=utf-8" },
-            { "name": "date", "value": "Thu, 07 Dec 2023 15:11:00 GMT" },
-            { "name": "etag", "value": "W/\"f-n9L/T8H7FjcXU5+wSuxCD+6xHlo\"" },
-            { "name": "keep-alive", "value": "timeout=5" },
-            { "name": "set-cookie", "value": "connect.sid=s%3AQhEmafnnGB6uPjxRFKwNdJg9MDQYmbkB.r0PBLNSKHdFLqMKbOVv%2FrgQVtN1i6JnbLElS%2Fzt7q%2F8; Path=/; Expires=Fri, 08 Dec 2023 15:11:00 GMT; HttpOnly" },
-            { "name": "x-powered-by", "value": "Express" }
-          ],
-          "content": {
-            "size": -1,
-            "mimeType": "text/html; charset=utf-8",
-            "_file": "9fd2ff4fc1fb163717539fb04aec420feeb11e5a.html"
-          },
-          "headersSize": -1,
-          "bodySize": -1,
-          "redirectURL": ""
-        },
-        "cache": {},
-        "timings": { "send": -1, "wait": -1, "receive": 50.718 }
-      }
-    ]
-  }
-}
\ No newline at end of file
diff --git a/web/frontend/tests/hars/123456/a03037964db4d746517f562ccb09b049db7f7a12.json b/web/frontend/tests/json/personal_info/123456.json
similarity index 100%
rename from web/frontend/tests/hars/123456/a03037964db4d746517f562ccb09b049db7f7a12.json
rename to web/frontend/tests/json/personal_info/123456.json
diff --git a/web/frontend/tests/hars/789012/5f05240cb33cb9e581ea0ce24c4e728a04e2a5d1.json b/web/frontend/tests/json/personal_info/789012.json
similarity index 100%
rename from web/frontend/tests/hars/789012/5f05240cb33cb9e581ea0ce24c4e728a04e2a5d1.json
rename to web/frontend/tests/json/personal_info/789012.json
diff --git a/web/frontend/tests/mocks.ts b/web/frontend/tests/mocks.ts
index b6acb1931..4b28d3918 100644
--- a/web/frontend/tests/mocks.ts
+++ b/web/frontend/tests/mocks.ts
@@ -1,24 +1,25 @@
 export const SCIPER_ADMIN = '123456';
 export const SCIPER_USER = '789012';
-export const UPDATE = false;
 
 export async function mockPersonalInfo(page: any, sciper?: string) {
   // clear current mock
   await page.unroute('/api/personal_info');
-  await page.routeFromHAR(`./tests/hars/${sciper ?? 'anonymous'}/personal_info.har`, {
-    url: '/api/personal_info',
-    update: UPDATE,
+  await page.route('/api/personal_info', async (route) => {
+    if (sciper) {
+      route.fulfill({ path: `./tests/json/personal_info/${sciper}.json` });
+    }
+    else {
+      route.fulfill({ status: 401, contentType: 'text/html', body: 'Unauthenticated'})
+    }
   });
 }
 
 export async function mockGetDevLogin(page: any) {
-  await page.routeFromHAR(`./tests/hars/${SCIPER_ADMIN}/get_dev_login.har`, {
-    url: `/api/get_dev_login/${SCIPER_ADMIN}`,
-    update: UPDATE,
+  await page.route(`/api/get_dev_login/${SCIPER_ADMIN}`, async (route) => {
+    await route.fulfill({});
   });
-  await page.routeFromHAR(`./tests/hars/${SCIPER_USER}/get_dev_login.har`, {
-    url: `/api/get_dev_login/${SCIPER_USER}`,
-    update: UPDATE,
+  await page.route(`/api/get_dev_login/${SCIPER_USER}`, async (route) => {
+    await route.fulfill({});
   });
   if (
     process.env.REACT_APP_SCIPER_ADMIN !== undefined &&
diff --git a/web/frontend/tests/navbar.spec.ts b/web/frontend/tests/navbar.spec.ts
index 71fed91a7..8dcef7851 100644
--- a/web/frontend/tests/navbar.spec.ts
+++ b/web/frontend/tests/navbar.spec.ts
@@ -7,50 +7,23 @@ import {
   logIn,
   setUp,
 } from './shared';
-import { SCIPER_ADMIN, SCIPER_USER, UPDATE, mockLogout, mockPersonalInfo } from './mocks';
+import { SCIPER_ADMIN, SCIPER_USER, mockLogout, mockPersonalInfo } from './mocks';
 
 initI18n();
 
 test.beforeEach(async ({ page }) => {
-  if (UPDATE === true) {
-    return;
-  }
-  await mockPersonalInfo(page);
-  await setUp(page, '/about');
-});
-
-// helper tests to update related HAR files
-
-test('Assert anonymous user HAR files are up-to-date', async ({ page }) => {
-  test.skip(UPDATE === false, 'Do not update HAR files');
   await mockPersonalInfo(page);
   await setUp(page, '/about');
 });
 
-test('Assert non-admin user HAR files are up-to-date', async ({ page }) => {
-  test.skip(UPDATE === false, 'Do not update HAR files');
-  await mockPersonalInfo(page, SCIPER_USER);
-  await page.context().request.get(`/api/get_dev_login/${SCIPER_USER}`);
-  await setUp(page, '/about');
-});
-
-test('Assert admin user HAR files are up-to-date', async ({ page }) => {
-  test.skip(UPDATE === false, 'Do not update HAR files');
-  await mockPersonalInfo(page, SCIPER_ADMIN);
-  await page.context().request.get(`/api/get_dev_login/${SCIPER_ADMIN}`);
-  await setUp(page, '/about');
-});
-
 // unauthenticated
 
 test('Assert cookie is set', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   const cookies = await page.context().cookies();
   await expect(cookies.find((cookie) => cookie.name === 'connect.sid')).toBeTruthy();
 });
 
 test('Assert D-Voting logo is present', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   const logo = await page.getByAltText(i18n.t('Workflow'));
   await expect(logo).toBeVisible();
   await logo.click();
@@ -58,7 +31,6 @@ test('Assert D-Voting logo is present', async ({ page }) => {
 });
 
 test('Assert link to form table is present', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   const forms = await page.getByRole('link', { name: i18n.t('navBarStatus') });
   await expect(forms).toBeVisible();
   await forms.click();
@@ -66,7 +38,6 @@ test('Assert link to form table is present', async ({ page }) => {
 });
 
 test('Assert "Login" button calls login API', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   page.waitForRequest(new RegExp('/api/get_dev_login/[0-9]{6}'));
   await page.getByRole('button', { name: i18n.t('login') }).click();
 });
@@ -74,7 +45,6 @@ test('Assert "Login" button calls login API', async ({ page }) => {
 // authenticated non-admin
 
 test('Assert "Profile" button is visible upon logging in', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   await assertOnlyVisibleToAuthenticated(
     page,
     page.getByRole('button', { name: i18n.t('Profile') })
@@ -82,7 +52,6 @@ test('Assert "Profile" button is visible upon logging in', async ({ page }) => {
 });
 
 test('Assert "Logout" calls logout API', async ({ page, baseURL }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   await mockLogout(page);
   await logIn(page, SCIPER_USER);
   page.waitForRequest(
@@ -100,7 +69,6 @@ test('Assert "Logout" calls logout API', async ({ page, baseURL }) => {
 // admin
 
 test('Assert "Create form" button is (only) visible to admin', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   await assertOnlyVisibleToAdmin(
     page,
     page.getByRole('link', { name: i18n.t('navBarCreateForm') })
@@ -108,6 +76,5 @@ test('Assert "Create form" button is (only) visible to admin', async ({ page })
 });
 
 test('Assert "Admin" button is (only) visible to admin', async ({ page }) => {
-  test.skip(UPDATE === true, 'Do not run regular tests when updating HAR files');
   await assertOnlyVisibleToAdmin(page, page.getByRole('link', { name: i18n.t('navBarAdmin') }));
 });

From d6c136a201e2c79bc1907e26b81062fc3fe9d2dd Mon Sep 17 00:00:00 2001
From: Carine Dengler <git@carine-dengler.de>
Date: Thu, 14 Dec 2023 15:38:08 +0100
Subject: [PATCH 5/6] fix: fix lint

---
 web/frontend/tests/formIndex.spec.ts | 18 +++++++++++++-----
 web/frontend/tests/mocks.ts          |  5 ++---
 web/frontend/tests/navbar.spec.ts    |  2 +-
 3 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/web/frontend/tests/formIndex.spec.ts b/web/frontend/tests/formIndex.spec.ts
index e16f184f8..f041f6527 100644
--- a/web/frontend/tests/formIndex.spec.ts
+++ b/web/frontend/tests/formIndex.spec.ts
@@ -1,7 +1,7 @@
 import { expect, test } from '@playwright/test';
 import { default as i18n } from 'i18next';
 import { assertHasFooter, assertHasNavBar, initI18n, setUp } from './shared';
-import { mockPersonalInfo, mockEvoting } from './mocks';
+import { mockEvoting, mockPersonalInfo } from './mocks';
 
 initI18n();
 
@@ -31,7 +31,9 @@ test('Assert pagination bar is present', async ({ page }) => {
 });
 
 test('Assert pagination works correctly for empty list', async ({ page }) => {
-  await expect(page.getByTestId('navPaginationMessage')).toHaveText(i18n.t('showingNOverMOfXResults', { n: 1, m: 1, x: 0 }));
+  await expect(page.getByTestId('navPaginationMessage')).toHaveText(
+    i18n.t('showingNOverMOfXResults', { n: 1, m: 1, x: 0 })
+  );
   for (let key of ['next', 'previous']) {
     await expect(page.getByRole('button', { name: i18n.t(key) })).toBeDisabled();
   }
@@ -44,17 +46,23 @@ test('Assert pagination works correctly for non-empty list', async ({ page }) =>
   const next = await page.getByRole('button', { name: i18n.t('next') });
   const previous = await page.getByRole('button', { name: i18n.t('previous') });
   // 1st page
-  await expect(page.getByTestId('navPaginationMessage')).toHaveText(i18n.t('showingNOverMOfXResults', { n: 1, m: 2, x: 11 }));
+  await expect(page.getByTestId('navPaginationMessage')).toHaveText(
+    i18n.t('showingNOverMOfXResults', { n: 1, m: 2, x: 11 })
+  );
   await expect(previous).toBeDisabled();
   await expect(next).toBeEnabled();
   await next.click();
   // 2nd page
-  await expect(page.getByTestId('navPaginationMessage')).toHaveText(i18n.t('showingNOverMOfXResults', { n: 2, m: 2, x: 11 }));
+  await expect(page.getByTestId('navPaginationMessage')).toHaveText(
+    i18n.t('showingNOverMOfXResults', { n: 2, m: 2, x: 11 })
+  );
   await expect(next).toBeDisabled();
   await expect(previous).toBeEnabled();
   await previous.click();
   // back to 1st page
-  await expect(page.getByTestId('navPaginationMessage')).toHaveText(i18n.t('showingNOverMOfXResults', { n: 1, m: 2, x: 11 }));
+  await expect(page.getByTestId('navPaginationMessage')).toHaveText(
+    i18n.t('showingNOverMOfXResults', { n: 1, m: 2, x: 11 })
+  );
   await expect(previous).toBeDisabled();
   await expect(next).toBeEnabled();
 });
diff --git a/web/frontend/tests/mocks.ts b/web/frontend/tests/mocks.ts
index 4b28d3918..363ba238e 100644
--- a/web/frontend/tests/mocks.ts
+++ b/web/frontend/tests/mocks.ts
@@ -7,9 +7,8 @@ export async function mockPersonalInfo(page: any, sciper?: string) {
   await page.route('/api/personal_info', async (route) => {
     if (sciper) {
       route.fulfill({ path: `./tests/json/personal_info/${sciper}.json` });
-    }
-    else {
-      route.fulfill({ status: 401, contentType: 'text/html', body: 'Unauthenticated'})
+    } else {
+      route.fulfill({ status: 401, contentType: 'text/html', body: 'Unauthenticated' });
     }
   });
 }
diff --git a/web/frontend/tests/navbar.spec.ts b/web/frontend/tests/navbar.spec.ts
index 8dcef7851..e20f4038a 100644
--- a/web/frontend/tests/navbar.spec.ts
+++ b/web/frontend/tests/navbar.spec.ts
@@ -7,7 +7,7 @@ import {
   logIn,
   setUp,
 } from './shared';
-import { SCIPER_ADMIN, SCIPER_USER, mockLogout, mockPersonalInfo } from './mocks';
+import { SCIPER_USER, mockLogout, mockPersonalInfo } from './mocks';
 
 initI18n();
 

From d30dbe2c9b86647337fdd5505d412f8c9d293736 Mon Sep 17 00:00:00 2001
From: Carine Dengler <git@carine-dengler.de>
Date: Fri, 15 Dec 2023 16:25:04 +0100
Subject: [PATCH 6/6] style: add missing type annotations

---
 web/frontend/tests/mocks.ts  | 10 +++++-----
 web/frontend/tests/shared.ts | 12 ++++++------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/web/frontend/tests/mocks.ts b/web/frontend/tests/mocks.ts
index 363ba238e..70d98ace2 100644
--- a/web/frontend/tests/mocks.ts
+++ b/web/frontend/tests/mocks.ts
@@ -1,7 +1,7 @@
 export const SCIPER_ADMIN = '123456';
 export const SCIPER_USER = '789012';
 
-export async function mockPersonalInfo(page: any, sciper?: string) {
+export async function mockPersonalInfo(page: page, sciper?: string) {
   // clear current mock
   await page.unroute('/api/personal_info');
   await page.route('/api/personal_info', async (route) => {
@@ -13,7 +13,7 @@ export async function mockPersonalInfo(page: any, sciper?: string) {
   });
 }
 
-export async function mockGetDevLogin(page: any) {
+export async function mockGetDevLogin(page: page) {
   await page.route(`/api/get_dev_login/${SCIPER_ADMIN}`, async (route) => {
     await route.fulfill({});
   });
@@ -31,13 +31,13 @@ export async function mockGetDevLogin(page: any) {
   }
 }
 
-export async function mockLogout(page: any) {
+export async function mockLogout(page: page) {
   await page.route('/api/logout', async (route) => {
     await route.fulfill({});
   });
 }
 
-export async function mockProxy(page: any) {
+export async function mockProxy(page: page) {
   await page.route('/api/config/proxy', async (route) => {
     await route.fulfill({
       status: 200,
@@ -51,7 +51,7 @@ export async function mockProxy(page: any) {
   });
 }
 
-export async function mockEvoting(page: any, empty: boolean = true) {
+export async function mockEvoting(page: page, empty: boolean = true) {
   // clear current mock
   await page.unroute(`${process.env.DELA_PROXY_URL}/evoting/forms`);
   await page.route(`${process.env.DELA_PROXY_URL}/evoting/forms`, async (route) => {
diff --git a/web/frontend/tests/shared.ts b/web/frontend/tests/shared.ts
index 7f549820c..f48994adc 100644
--- a/web/frontend/tests/shared.ts
+++ b/web/frontend/tests/shared.ts
@@ -19,7 +19,7 @@ export function initI18n() {
   });
 }
 
-export async function setUp(page: any, url: string) {
+export async function setUp(page: page, url: string) {
   await mockProxy(page);
   await mockGetDevLogin(page);
   await mockLogout(page);
@@ -27,19 +27,19 @@ export async function setUp(page: any, url: string) {
   await expect(page).toHaveURL(url); // make sure that page is loaded
 }
 
-export async function logIn(page: any, sciper: string) {
+export async function logIn(page: page, sciper: string) {
   await mockPersonalInfo(page, sciper);
   await page.reload();
   await expect(page).toHaveURL(page.url()); // make sure that page is loaded
 }
 
-export async function assertOnlyVisibleToAuthenticated(page: any, locator: any) {
+export async function assertOnlyVisibleToAuthenticated(page: page, locator: locator) {
   await expect(locator).toBeHidden(); // assert is hidden to unauthenticated user
   await logIn(page, SCIPER_USER);
   await expect(locator).toBeVisible(); // assert is visible to authenticated user
 }
 
-export async function assertOnlyVisibleToAdmin(page: any, locator: any) {
+export async function assertOnlyVisibleToAdmin(page: page, locator: locator) {
   await expect(locator).toBeHidden(); // assert is hidden to unauthenticated user
   await logIn(page, SCIPER_USER);
   await expect(locator).toBeHidden(); // assert is hidden to authenticated non-admin user
@@ -47,10 +47,10 @@ export async function assertOnlyVisibleToAdmin(page: any, locator: any) {
   await expect(locator).toBeVisible(); // assert is visible to admin user
 }
 
-export async function assertHasNavBar(page: any) {
+export async function assertHasNavBar(page: page) {
   await expect(page.getByTestId('navBar')).toBeVisible();
 }
 
-export async function assertHasFooter(page: any) {
+export async function assertHasFooter(page: page) {
   await expect(page.getByTestId('footer')).toBeVisible();
 }