From c6a96d15b8416b9b7a3b256e8fe6ca36652b0885 Mon Sep 17 00:00:00 2001 From: paul-lawlor-tco Date: Tue, 26 Sep 2023 13:46:37 +0100 Subject: [PATCH 1/3] Changed copy to be consistent with the description shown to applicants for file upload. --- .../[applicationId]/[sectionId]/question-type.page.tsx | 2 +- .../src/components/question-page/inputs/DocumentUpload.tsx | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/admin/src/pages/build-application/[applicationId]/[sectionId]/question-type.page.tsx b/packages/admin/src/pages/build-application/[applicationId]/[sectionId]/question-type.page.tsx index e70aa1572..8406da866 100644 --- a/packages/admin/src/pages/build-application/[applicationId]/[sectionId]/question-type.page.tsx +++ b/packages/admin/src/pages/build-application/[applicationId]/[sectionId]/question-type.page.tsx @@ -257,7 +257,7 @@ const QuestionType = ({ value: ResponseType.SingleFileUpload, hint: ( - Upload a file (all documents except .xls and .exe) + Upload a file (Allows files that are .DOC, .DOCX, .ODT, .PDF, .XLS, + .XLSX or .ZIP) From 3ebdf765696230b8202b003ad9ca3621c6bdec56 Mon Sep 17 00:00:00 2001 From: paul-lawlor-tco Date: Tue, 26 Sep 2023 14:30:53 +0100 Subject: [PATCH 2/3] Modified unit test 'Should have a document upload answer' to get the right text --- .../[applicationId]/[sectionId]/question-type.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/admin/src/pages/build-application/[applicationId]/[sectionId]/question-type.test.tsx b/packages/admin/src/pages/build-application/[applicationId]/[sectionId]/question-type.test.tsx index 88e98ecef..e78bd6274 100644 --- a/packages/admin/src/pages/build-application/[applicationId]/[sectionId]/question-type.test.tsx +++ b/packages/admin/src/pages/build-application/[applicationId]/[sectionId]/question-type.test.tsx @@ -125,7 +125,7 @@ describe('Question type', () => { render(component); screen.getByRole('radio', { name: 'Document upload' }); screen.getByText( - 'Allows all documents except .xls and .exe to be uploaded.' + 'Allows files that are .DOC, .DOCX, .ODT, .PDF, .XLS, .XLSX or .ZIP' ); }); From 8e17b3cecfd1daf9d1b4fdc2fd1b39398c28c033 Mon Sep 17 00:00:00 2001 From: paul-lawlor-tco Date: Tue, 26 Sep 2023 16:26:03 +0100 Subject: [PATCH 3/3] Fixed failing unit test --- .../components/question-page/inputs/DocumentUpload.test.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/gap-web-ui/src/components/question-page/inputs/DocumentUpload.test.tsx b/packages/gap-web-ui/src/components/question-page/inputs/DocumentUpload.test.tsx index 99610c9df..5cc623fa3 100644 --- a/packages/gap-web-ui/src/components/question-page/inputs/DocumentUpload.test.tsx +++ b/packages/gap-web-ui/src/components/question-page/inputs/DocumentUpload.test.tsx @@ -56,7 +56,9 @@ describe('Document Upload component', () => { it('Should render a label with the relevant accepted doc types', () => { render(); - screen.getByText('Upload a file (all documents except .xls and .exe)'); + screen.getByText( + 'Upload a file (Allows files that are .DOC, .DOCX, .ODT, .PDF, .XLS, .XLSX or .ZIP)' + ); }); it('Should NOT render an error message when there are no field errors', () => {