diff --git a/handshake.go b/handshake.go index 2359bd04..d93972f8 100644 --- a/handshake.go +++ b/handshake.go @@ -293,7 +293,7 @@ func (cfg *Config) getCertDuringHandshake(hello *tls.ClientHelloInfo, loadIfNece // TODO: As suggested here, https://caddy.community/t/error-tls-alert-internal-error-592-again/13272/30?u=matt, // it might be a good idea to check with the DecisionFunc or allowlist first before even loading the certificate // from storage, since if we can't renew it, why should we even try serving it (it will just get evicted after - // we get a return value of false anyway)? + // we get a return value of false anyway)? See issue #174 loadedCert, err := cfg.CacheManagedCertificate(ctx, name) if errors.Is(err, fs.ErrNotExist) { // If no exact match, try a wildcard variant, which is something we can still use diff --git a/maintain.go b/maintain.go index 6e376b5f..e884447f 100644 --- a/maintain.go +++ b/maintain.go @@ -79,7 +79,6 @@ func (certCache *Cache) maintainAssets(panicCount int) { case <-certCache.stopChan: renewalTicker.Stop() ocspTicker.Stop() - // TODO: stop any in-progress maintenance operations and clear locks we made (this might be done now with our use of context) if log != nil { log.Info("stopped background certificate maintenance") }