From ab3d41c2694893f72cc8462ad78c566adaa009bd Mon Sep 17 00:00:00 2001 From: Shijie Sheng Date: Thu, 2 Jan 2025 14:00:37 -0800 Subject: [PATCH] fix AutoConfigHint field propagation in frontend (#6587) New field was not passed to the wire correctly. --- common/types/mapper/proto/api.go | 4 ++++ common/types/mapper/thrift/matching.go | 2 ++ common/types/mapper/thrift/shared.go | 4 ++++ common/types/testdata/service_frontend.go | 2 ++ common/types/testdata/service_matching.go | 1 + 5 files changed, 13 insertions(+) diff --git a/common/types/mapper/proto/api.go b/common/types/mapper/proto/api.go index 21b03d555d1..babecda8127 100644 --- a/common/types/mapper/proto/api.go +++ b/common/types/mapper/proto/api.go @@ -2178,6 +2178,7 @@ func FromPollForActivityTaskResponse(t *types.PollForActivityTaskResponse) *apiv WorkflowType: FromWorkflowType(t.WorkflowType), WorkflowDomain: t.WorkflowDomain, Header: FromHeader(t.Header), + AutoConfigHint: FromAutoConfigHint(t.AutoConfigHint), } } @@ -2202,6 +2203,7 @@ func ToPollForActivityTaskResponse(t *apiv1.PollForActivityTaskResponse) *types. WorkflowType: ToWorkflowType(t.WorkflowType), WorkflowDomain: t.WorkflowDomain, Header: ToHeader(t.Header), + AutoConfigHint: ToAutoConfigHint(t.AutoConfigHint), } } @@ -2250,6 +2252,7 @@ func FromPollForDecisionTaskResponse(t *types.PollForDecisionTaskResponse) *apiv Queries: FromWorkflowQueryMap(t.Queries), NextEventId: t.NextEventID, TotalHistoryBytes: t.TotalHistoryBytes, + AutoConfigHint: FromAutoConfigHint(t.AutoConfigHint), } } @@ -2274,6 +2277,7 @@ func ToPollForDecisionTaskResponse(t *apiv1.PollForDecisionTaskResponse) *types. Queries: ToWorkflowQueryMap(t.Queries), NextEventID: t.NextEventId, TotalHistoryBytes: t.TotalHistoryBytes, + AutoConfigHint: ToAutoConfigHint(t.AutoConfigHint), } } diff --git a/common/types/mapper/thrift/matching.go b/common/types/mapper/thrift/matching.go index 3ef4650eccd..86779f972df 100644 --- a/common/types/mapper/thrift/matching.go +++ b/common/types/mapper/thrift/matching.go @@ -346,6 +346,7 @@ func FromMatchingPollForActivityTaskResponse(t *types.MatchingPollForActivityTas WorkflowType: FromWorkflowType(t.WorkflowType), WorkflowDomain: &t.WorkflowDomain, Header: FromHeader(t.Header), + AutoConfigHint: FromAutoConfigHint(t.AutoConfigHint), } } @@ -370,6 +371,7 @@ func ToMatchingPollForActivityTaskResponse(t *shared.PollForActivityTaskResponse WorkflowType: ToWorkflowType(t.WorkflowType), WorkflowDomain: t.GetWorkflowDomain(), Header: ToHeader(t.Header), + AutoConfigHint: ToAutoConfigHint(t.AutoConfigHint), } } diff --git a/common/types/mapper/thrift/shared.go b/common/types/mapper/thrift/shared.go index 5dedcf36916..1fa54f828d9 100644 --- a/common/types/mapper/thrift/shared.go +++ b/common/types/mapper/thrift/shared.go @@ -3589,6 +3589,7 @@ func FromPollForActivityTaskResponse(t *types.PollForActivityTaskResponse) *shar WorkflowType: FromWorkflowType(t.WorkflowType), WorkflowDomain: &t.WorkflowDomain, Header: FromHeader(t.Header), + AutoConfigHint: FromAutoConfigHint(t.AutoConfigHint), } } @@ -3614,6 +3615,7 @@ func ToPollForActivityTaskResponse(t *shared.PollForActivityTaskResponse) *types WorkflowType: ToWorkflowType(t.WorkflowType), WorkflowDomain: t.GetWorkflowDomain(), Header: ToHeader(t.Header), + AutoConfigHint: ToAutoConfigHint(t.AutoConfigHint), } } @@ -3665,6 +3667,7 @@ func FromPollForDecisionTaskResponse(t *types.PollForDecisionTaskResponse) *shar Queries: FromWorkflowQueryMap(t.Queries), NextEventId: &t.NextEventID, TotalHistoryBytes: &t.TotalHistoryBytes, + AutoConfigHint: FromAutoConfigHint(t.AutoConfigHint), } } @@ -3690,6 +3693,7 @@ func ToPollForDecisionTaskResponse(t *shared.PollForDecisionTaskResponse) *types Queries: ToWorkflowQueryMap(t.Queries), NextEventID: t.GetNextEventId(), TotalHistoryBytes: t.GetTotalHistoryBytes(), + AutoConfigHint: ToAutoConfigHint(t.AutoConfigHint), } } diff --git a/common/types/testdata/service_frontend.go b/common/types/testdata/service_frontend.go index e13ee1d59c1..a9dd1102d34 100644 --- a/common/types/testdata/service_frontend.go +++ b/common/types/testdata/service_frontend.go @@ -186,6 +186,7 @@ var ( StartedTimestamp: &Timestamp2, Queries: WorkflowQueryMap, NextEventID: EventID3, + AutoConfigHint: &AutoConfigHint, } RespondDecisionTaskCompletedRequest = types.RespondDecisionTaskCompletedRequest{ TaskToken: TaskToken, @@ -232,6 +233,7 @@ var ( WorkflowType: &WorkflowType, WorkflowDomain: DomainName, Header: &Header, + AutoConfigHint: &AutoConfigHint, } RespondActivityTaskCompletedRequest = types.RespondActivityTaskCompletedRequest{ TaskToken: TaskToken, diff --git a/common/types/testdata/service_matching.go b/common/types/testdata/service_matching.go index e36c9a80603..28185050274 100644 --- a/common/types/testdata/service_matching.go +++ b/common/types/testdata/service_matching.go @@ -115,6 +115,7 @@ var ( Header: &Header, PartitionConfig: &TaskListPartitionConfig, LoadBalancerHints: &LoadBalancerHints, + AutoConfigHint: &AutoConfigHint, } MatchingPollForDecisionTaskRequest = types.MatchingPollForDecisionTaskRequest{ DomainUUID: DomainID,