Bug: Make fct_daily_schedule_feed_validation_notices
properly validator version-aware
#1994
Labels
bug
Something isn't working
Describe the bug
Uncovered in review of #1960.
Our
fct_daily_schedule_feed_validation_notices
table does not properly account for validator versioning, because the cross join does not check for which validator version we were actually running on a given date, and the way that weCOALESCE
the results means that we imply that if any validator ran that we can count 0 notices for all codes, even codes that did not exist in the validator version that was run on that day.There are at least two specific symptoms of this that we need to address:
gtfs_validator_version
column is null for rows with zero notices.gtfs_validator_version
should be populated for all rows to reflect what validator version actually ran against that feed on that date.I think to fix this we may need to start listing the validator version that was run in the validations outcome file, not just in the validations files themselves, to account for cases where a feed returns 0 notices. We should be recording which validator version was actually run against each feed each day. Ambivalent on whether we can/should backfill this information if we can get the right outcome without doing so.
We also need to fix the actual SQL to record this information.
Acceptance criteria:
gtfs_validator_version
not null check?The text was updated successfully, but these errors were encountered: