From ae96cd2c69402c73faab61ce24edd4cdd95e372c Mon Sep 17 00:00:00 2001
From: Angela Tran <angela@compiler.la>
Date: Thu, 24 Aug 2023 16:00:02 +0000
Subject: [PATCH] fix: separate out into separate jobs in attempt to make
 validation work

getting error:
> Job terraform: Step references task 'ManualValidation'
> at version '0.198.0' which is not valid for the given job target.
---
 experiment-pipeline.yml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/experiment-pipeline.yml b/experiment-pipeline.yml
index ff475ac0..555ec80a 100644
--- a/experiment-pipeline.yml
+++ b/experiment-pipeline.yml
@@ -19,7 +19,7 @@ stages:
     pool:
       vmImage: ubuntu-latest
     jobs:
-      - job: terraform
+      - job: "Plan"
         variables:
           - name: OTHER_SOURCE
             value: $[variables['System.PullRequest.SourceBranch']]
@@ -30,8 +30,6 @@ stages:
           - name: TARGET
             value: $[variables['System.PullRequest.TargetBranch']]
         steps:
-          - bash: |
-              echo $(IS_TAG)
           # set the workspace variable at runtime (rather than build time) so that all the necessary variables are available, and we can use Python
           # https://learn.microsoft.com/en-us/azure/devops/pipelines/process/set-variables-scripts?view=azure-devops&tabs=bash#about-tasksetvariable
           - bash: |
@@ -93,6 +91,8 @@ stages:
               script: echo "terraform plan"
             # the plan is done as part of the apply (below), so don't bother doing it twice
             condition: notIn(variables['Build.SourceBranchName'], 'dev', 'test', 'prod')
+      - job: "ManualApproval"
+        steps:
           # - task: TerraformTaskV3@
           - task: ManualValidation@0
             timeoutInMinutes: "1440" # task times out in 1 day
@@ -101,6 +101,8 @@ stages:
                 angela@compiler.la
               instructions: "Please review the output of Terraform plan before approving."
               onTimeout: "reject"
+      - job: "Apply"
+        steps:
           - task: Bash@3
             displayName: Terraform apply
             inputs: