Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Time.java constants from int to long #210

Open
owades opened this issue Mar 31, 2022 · 0 comments
Open

Switch Time.java constants from int to long #210

owades opened this issue Mar 31, 2022 · 0 comments

Comments

@owades
Copy link
Member

owades commented Mar 31, 2022

When you multiply an int by a long in Java, the result will be a long and thus have more memory allocated. When multiplying big ints, we run the risk of an overflow (where result goes negative). By changing int to long, the product will be a long and thus not overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant