Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapidfuzz not present in bap Python package dependencies #37

Open
aksarkar opened this issue Apr 21, 2023 · 2 comments
Open

rapidfuzz not present in bap Python package dependencies #37

aksarkar opened this issue Apr 21, 2023 · 2 comments

Comments

@aksarkar
Copy link

bap/setup.py

Line 7 in 44061cd

dependencies = ['biopython','fuzzysearch','click', 'pytest', 'snakemake', 'optparse-pretty', 'multiprocess', 'regex', 'pysam', 'ruamel.yaml', 'biopython']

This lead to a missing dependency in our internally built conda package metadata that wasn't discovered until runtime.

@caleblareau
Copy link
Owner

thanks! is the fix as simple as adding this to the line that you noted?

@aksarkar
Copy link
Author

aksarkar commented May 2, 2023

Yes, that should fix the issue.

The issue also affects the installation instructions given in the wiki, since pip install bap-atac does not pull in rapidfuzz either, and then bap-barcode fails silently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants