From c0a8385a7735bf12e24912cfccd08bd7cd48cf12 Mon Sep 17 00:00:00 2001 From: nonoakij <45055030+nonoakij@users.noreply.github.com> Date: Mon, 1 Apr 2024 23:43:10 +0900 Subject: [PATCH 1/4] fix(nodejs): patition option is ture by default --- packages/nodejs/src/helpers/cookies.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/nodejs/src/helpers/cookies.ts b/packages/nodejs/src/helpers/cookies.ts index 2bc1c5913..2e58f5220 100644 --- a/packages/nodejs/src/helpers/cookies.ts +++ b/packages/nodejs/src/helpers/cookies.ts @@ -25,7 +25,8 @@ export const genCookie = ( opts.sameSite = 'none'; } if (opts.partitioned === undefined) { - opts.partitioned = true; + // TODO: Set to true by default after all 3pcd support is complete + opts.partitioned = false; } return serialize(key, value, opts); }; From a70f57bebf46e8d1352067194437c9380bcbcdb5 Mon Sep 17 00:00:00 2001 From: nonoakij <45055030+nonoakij@users.noreply.github.com> Date: Mon, 1 Apr 2024 23:46:32 +0900 Subject: [PATCH 2/4] intent(): changeset --- .changeset/spotty-kangaroos-shout.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/spotty-kangaroos-shout.md diff --git a/.changeset/spotty-kangaroos-shout.md b/.changeset/spotty-kangaroos-shout.md new file mode 100644 index 000000000..eab3bd207 --- /dev/null +++ b/.changeset/spotty-kangaroos-shout.md @@ -0,0 +1,5 @@ +--- +"@viron/lib": patch +--- + +Set patition option is false by default From 9ededa4b9a3ee1fc79fa84e3ff04b132038a6d3e Mon Sep 17 00:00:00 2001 From: Aki Matsumoto <45055030+nonoakij@users.noreply.github.com> Date: Tue, 2 Apr 2024 15:01:35 +0900 Subject: [PATCH 3/4] Update .changeset/spotty-kangaroos-shout.md --- .changeset/spotty-kangaroos-shout.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/spotty-kangaroos-shout.md b/.changeset/spotty-kangaroos-shout.md index eab3bd207..322995d4a 100644 --- a/.changeset/spotty-kangaroos-shout.md +++ b/.changeset/spotty-kangaroos-shout.md @@ -2,4 +2,4 @@ "@viron/lib": patch --- -Set patition option is false by default +Set the partition option to false as the default. From 9c5511981eeedc168a6f4d149e7c83894b2a0d9b Mon Sep 17 00:00:00 2001 From: nonoakij <45055030+nonoakij@users.noreply.github.com> Date: Tue, 2 Apr 2024 15:06:19 +0900 Subject: [PATCH 4/4] fix(nodejs): to comment --- packages/nodejs/src/helpers/cookies.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/nodejs/src/helpers/cookies.ts b/packages/nodejs/src/helpers/cookies.ts index 2e58f5220..122b5087e 100644 --- a/packages/nodejs/src/helpers/cookies.ts +++ b/packages/nodejs/src/helpers/cookies.ts @@ -24,10 +24,10 @@ export const genCookie = ( if (!opts.sameSite) { opts.sameSite = 'none'; } - if (opts.partitioned === undefined) { - // TODO: Set to true by default after all 3pcd support is complete - opts.partitioned = false; - } + // TODO: Set to true by default after all 3pcd support is complete + // if (opts.partitioned === undefined) { + // opts.partitioned = true; + // } return serialize(key, value, opts); };