Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create IDs for Method Documents #263

Open
korikuzma opened this issue Dec 19, 2023 · 2 comments
Open

Create IDs for Method Documents #263

korikuzma opened this issue Dec 19, 2023 · 2 comments
Labels
enhancement New feature or request gk-pilot Issues or pull requests related to gk pilot priority:low Low priority

Comments

@korikuzma
Copy link
Member

Documents in Methods do not contain IDs. We should create an ID using _get_digest_for_str_lists

_methods: List[Method] = [
Method(
id=MethodId.CIVIC_EID_SOP,
label="CIViC Curation SOP (2019)",
isReportedIn=Document(
label="Danos et al., 2019, Genome Med.",
title="Standard operating procedure for curation and clinical interpretation of variants in cancer", # noqa: E501
doi="10.1186/s13073-019-0687-x",
pmid=31779674
)
).model_dump(exclude_none=True),
Method(
id=MethodId.MOA_ASSERTION_BIORXIV,
label="MOAlmanac (2021)",
isReportedIn=Document(
label="Reardon, B., Moore, N.D., Moore, N.S. et al.",
title="Integrating molecular profiles into clinical frameworks through the Molecular Oncology Almanac to prospectively guide precision oncology", # noqa: E501
doi="10.1038/s43018-021-00243-3",
pmid=35121878
)
).model_dump(exclude_none=True),
]

@korikuzma korikuzma added enhancement New feature or request priority:low Low priority gk-pilot Issues or pull requests related to gk pilot labels Dec 19, 2023
Copy link

This issue is stale because it has been open 45 days with no activity. Please make a comment for triaging or closing the issue.

@github-actions github-actions bot added the stale label May 12, 2024
@korikuzma korikuzma removed the stale label May 13, 2024
@jsstevenson
Copy link
Member

It'd be nice if we could use PMIDs or DOIs preferentially so that, when they're available, the same document can be referenced by multiple sources (obviously this isn't an option for FDA stuff or NCCN guidelines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gk-pilot Issues or pull requests related to gk pilot priority:low Low priority
Projects
None yet
Development

No branches or pull requests

2 participants