Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charm-libs): better error message on bad version type #1955

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(charm-libs): better error message on bad version type #1955

merged 1 commit into from
Dec 11, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Oct 11, 2024

Fixes #1954

@lengau lengau mentioned this pull request Oct 11, 2024
Closed
@lengau lengau requested review from bepri and mr-cal December 10, 2024 16:35
bepri
bepri approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@bepri bepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lengau lengau merged commit 31418c9 into main Dec 11, 2024
11 of 19 checks passed
@lengau lengau deleted the work/1954 branch December 11, 2024 18:09
lengau added a commit to tmihoc/charmcraft that referenced this pull request Dec 19, 2024
@lengau
fix(charm-libs): better error message on bad version type (canonical#…
46632e0 
…1955)

Fixes canonical#1954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bepri bepri bepri approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error message is unhelpful when parsing charmcraft.yaml fails because charm-libs[*].version is an integer
3 participants
@lengau @bepri @mr-cal