Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change poetry plugin keep bins default to True #2026

Closed

Conversation

carlcsaposs-canonical
Copy link
Contributor

Including bin/activate in the virtual environment by default will make debugging much easier (charm developers can easily run Python code using the charm's virtual environment to debug issues)

@lengau to confirm, this won't have negative side effects of including a symlink to the python binary or copying the python binary itself into the *.charm artifact?

Including `bin/activate` in the virtual environment by default will make debugging much easier (charm developers can easily run Python code using the charm's virtual environment to debug issues)

@lengau to confirm, this won't have negative side effects of including a symlink to the python binary or copying the python binary itself into the *.charm artifact?
@carlcsaposs-canonical
Copy link
Contributor Author

@lengau to confirm, this won't have negative side effects of including a symlink to the python binary or copying the python binary itself into the *.charm artifact?

testing shows python bins are not included

$ ls venv/bin/
Activate.ps1  activate  activate.csh  activate.fish  httpx  jsonschema  normalizer  wsdump

@carlcsaposs-canonical
Copy link
Contributor Author

Closed in favor of #2036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant