feat(tracing): Add commented out tracing relation into templates #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkandersson
approved these changes
Jan 28, 2025
# Conflicts: # docs/reference/extensions/django-framework-extension.md # docs/reference/extensions/fastapi-framework-extension.md # docs/reference/extensions/flask-framework-extension.md # docs/reference/extensions/go-framework-extension.md
alithethird
force-pushed
the
12factor-tracing
branch
from
b34d115 to
b064c19
Compare
jdkandersson
reviewed
Feb 7, 2025
There was a problem hiding this comment.
We will also need to update the extensions to add the tracing library into charmcraft.yaml, see
charmcraft/charmcraft/extensions/app.py
Line 39 in 92111c5
javierdelapuente
approved these changes
Feb 7, 2025
medubelko
approved these changes
Feb 11, 2025
erinecon
approved these changes
Feb 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Paas Charm PR.
Adds the possibility to integrate with Tempo Operator to trace the 12 Factor app workload for current frameworks(go, django, flask, fastapi).
Changes:
tracingrelation required objects to extensioncharmcraft.yaml.j2files.reviewers:
@jdkandersson
@javierdelapuente