Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clearer where a step failed #479

Open
samuelallan72 opened this issue Jul 3, 2024 · 2 comments
Open

Make it clearer where a step failed #479

samuelallan72 opened this issue Jul 3, 2024 · 2 comments

Comments

@samuelallan72
Copy link
Contributor

I had this case:

$ cou upgrade --auto-approve
...
Upgrade plan for 'neutron-api-plugin-ovn' to 'victoria' executed in 2 seconds ✔
Upgrade plan for 'octavia-dashboard' to 'victoria' executed in 2 seconds ✔
Upgrade plan for 'octavia-diskimage-retrofit' to 'victoria' executed in 2 seconds ✔
Verify that all 'nova-compute' units has been upgraded ✖
2024-07-03 06:54:49 [ERROR] Units 'nova-compute/0, nova-compute/1, nova-compute/2, nova-compute/3, nova-compute/4' did not reach victoria.
2024-07-03 06:54:49 [ERROR] See the known issues at https://canonical-charmed-openstack-upgrader.readthedocs-hosted.com/en/stable/reference/known-issues/

I can see that Verify that all 'nova-compute' units has been upgraded ✖ step failed, but this comes directly after Upgrade plan for 'octavia-diskimage-retrofit' to 'victoria' executed in 2 seconds ✔. My first thought is "why is it verifying upgraded before it's actually upgraded the units?". It would be good to print each step/substep before it's executed so we can have a complete log of steps with the default verbosity.

@Pjack
Copy link

Pjack commented Sep 5, 2024

@samuelallan72 Could you provide more insight that what happend between step3(upgrade octavia-diskimage-retrofit) and step4 (Verify 'nova-compute)?

@samuelallan72
Copy link
Contributor Author

@Pjack this isn't about this specific failure, this is about in general providing more useful output to stdout. There is more output of the steps in the logs, but we should be providing better information directly to the user at the console output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants