Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wwan_resource should slugify the values #1510

Open
pieqq opened this issue Sep 27, 2024 · 2 comments
Open

wwan_resource should slugify the values #1510

pieqq opened this issue Sep 27, 2024 · 2 comments
Labels
bug Something isn't working Critical

Comments

@pieqq
Copy link
Collaborator

pieqq commented Sep 27, 2024

Bug Description

On a device, wwan_resource has the following outcome:

--------------------[ Gather device info about WWAN modems ]--------------------
ID: com.canonical.certification::wwan_resource
Category: com.canonical.certification::wwan
... 8< -------------------------------------------------------------------------
mm_id: 2
hw_id: 357953120018642
manufacturer: mtk
model: MBIM [14C0:4D75]
firmware_revision: demo
hardware_revision: demo

(Note: firmware_revision and hardware_revision have been hardcoded due to another bug, #1505 )

model has spaces in it, which results in job ids with spaces, such as wwan/check-sim-present-mtk-MBIM [14C0:4D75]-357953120018642-auto.

The problem is some of these jobs ids are used as a dependency entry for other jobs. In that case, when executed, the depends field becomes:

depends: wwan/check-sim-present-mtk-MBIM [14C0:4D75]-357953120018642-auto

which tells Checkbox to look for 2 jobs:

  • wwan/check-sim-present-mtk-MBIM
  • [14C0:4D75]-357953120018642-auto

Since these jobs don't exist, the job they depend on is not run at all.

The wwan_resource job should slugify its values.

To Reproduce

  1. run checkbox-cli expand com.canonical.certification::wwan-automated
  2. run checkbox-cli list-bootstrapped com.canonical.certification::wwan-automated

In the first command, you should see the different templates and jobs that should be executed:

Template 'com.canonical.certification::wwan/3gpp-scan-manufacturer-model-hw_id-auto'
Template 'com.canonical.certification::wwan/check-sim-present-manufacturer-model-hw_id-auto'
Job 'com.canonical.certification::wwan/detect'
Template 'com.canonical.certification::wwan/gsm-connection-manufacturer-model-hw_id-auto'

In the second command, you should see them as well, but in practice, you only see

com.canonical.certification::wwan/check-sim-present-mtk-MBIM [14C0:4D75]-357953120018642-auto
com.canonical.certification::wwan/detect

Environment

Checkbox dev

Relevant log output

No response

Additional context

No response

@pieqq pieqq added the bug Something isn't working label Sep 27, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CHECKBOX-1592.

This message was autogenerated

@scotthu27
Copy link
Contributor

All this lead to WWAN cases would be skipped or without be generated on PC projects.
Here are the wwan_resource which PC projects used in this NPI phase.

mm_id: 0
hw_id: 358988870026717
manufacturer: DELL
model: DW5826e Qualcomm Snapdragon X12 Global LTE-A
firmware_revision: ZX2519.00226.03.00_04.10_GEN
hardware_revision: EXM-G1A

mm_id: 0
hw_id: 356566810384560
manufacturer: foxconn
model: DELL Snapdragon X62
firmware_revision: FDE.F0.3.0.1.1.GC.002
063
hardware_revision: DELL Snapdragon X62

mm_id: 1
hw_id: 357953120018642
manufacturer: mtk
model: MBIM [14C0:4D75]
firmware_revision: demo
hardware_revision: demo

mm_id: 0
hw_id: 358893170010355
manufacturer: foxconn
model: DP25-42843-47
firmware_revision: FDE2.F0.0.0.1.2.GC.001
020
hardware_revision: DP25-42843-47

@scotthu27 scotthu27 reopened this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Critical
Projects
None yet
Development

No branches or pull requests

2 participants