Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup scenario fixtures #256

Open
sed-i opened this issue Sep 26, 2023 · 0 comments
Open

Cleanup scenario fixtures #256

sed-i opened this issue Sep 26, 2023 · 0 comments

Comments

@sed-i
Copy link
Contributor

sed-i commented Sep 26, 2023

After we split the hybrid repo into k8s and machine (#254), feels like this entire function should probably be removed. Or at the very least rewritten as return charm.GrafanaAgentK8sCharm.

@pytest.fixture
def charm_type(substrate) -> Type[CharmType]:
return {"k8s": charm.GrafanaAgentK8sCharm}[substrate]

@pytest.fixture
def charm_meta(substrate, charm_type) -> dict:
fname = {"k8s": "metadata"}[substrate]

Originally posted by @dstathis in #254 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant