Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flags to be more explicit #72

Open
dgtlntv opened this issue Oct 3, 2024 · 0 comments
Open

Rename flags to be more explicit #72

dgtlntv opened this issue Oct 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dgtlntv
Copy link
Member

dgtlntv commented Oct 3, 2024

The --name flag in the cluster add command and the --manifest-file in the manifest generatecommand could be more explicit in their expected values.

The --name flag could be renamed to --fqdn as the FQDN of the joining node is what is expected to be passed in this flag.

The --manifest-file in the manifest generatecommand could be renamed to --output/-o as that seems to be the standard amongst CLIs as the flag when an ouput path for a file needs to be provided.

@skatsaounis skatsaounis added the enhancement New feature or request label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants