Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong tags when adding multiple Rocks to OCI Factory #152

Closed
lucabello opened this issue Mar 15, 2024 · 0 comments · Fixed by #154
Closed

Wrong tags when adding multiple Rocks to OCI Factory #152

lucabello opened this issue Mar 15, 2024 · 0 comments · Fixed by #154

Comments

@lucabello
Copy link
Contributor

There's a bug in our CI workflow that opens a PR to OCI Factory.

As you can see in this file (produced by our CI), multiple images are assigned the major 10-22.04 tag, which is obviously wrong (only 10.3.3 should have it, not 10.3.1).

The way we decide what to tag with major.minor and major is based on checking against the list of already-existing tags. However, this means that if we now add 11.0, 11.1, and 11.2 in the same PR, they will all be tagged as 11, which is wrong.

The CI needs to be modified to not only check against already-existing tags, but on the union of that and the tags being added/modified by the PR itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant