-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapcraft: Move part lifecycle information into a reference #148
Comments
Hi @medubelko, I would like to work on this issue. Could you please assign it to me? |
Salut @Sophie-Pages! I've assigned this to you. Can you please provide an estimated completion date? |
Hi @medubelko, thank you! Yes, of course! I plan to have the first version by the beginning of next week at the latest. Is that okay with you, or do you need a first version for this week? |
@Sophie-Pages That would great! The first draft doesn't have to be very refined – I'd like to review the structure of the page to ensure you're on the right foot before we put lots of time and effort into the complete product. And of course, let me know if you have any technical issues with the repository. Thanks again! |
Hi @medubelko, following CODA's guidelines, I created a pull request with a draft of the Parts lifecycle reference here: #163. I have a few questions/remarks:
|
Hi Sophie,
That looks to be an error.
Overlays are related to copying the host's base filesystem, and Snapcraft doesn't use them.
I planned for this to be one document, which would be make it easier on the reader's comprehension and the TOC. I don't believe there are enough unique facets with how Snapcraft implements parts that it need be that much longer than the existing topic in Craft Parts. I saw the bigger challenge as how to reconverge the text about parts that's spread to other pages. For example, Parts and Steps would need to be renamed because it's about a lower-level implementation, but should its Step output directories section be exctracted and put in the updated lifecycle page? Questions like these need addressing. Do you think the content is too long for one page?
Yes! That's the correct (but slightly roundabout) process. Don't worry if there are bits that don't render in GitHub's Markdown preview – that's to be expected. |
Hi @medubelko, Thank you for clarifying the organize and overlay steps.
We can absolutely add the Step output directories to the reference. I believe most of the information is already in the reference but I will need to check. If you see anything else that may be missing, don't hesitate to tell me. I'll work on the inconsistencies and hope to provide a pull request by next week. While working on that, I may find other information that could be missing from the reference. |
Hi @medubelko, I updated my existing pull request with new commits. What I did: I added new information in the reference and removed duplicate information from Parts lifecycle and How Snapcraft build a snap. I believe we could clean Parts lifecycle even more from duplicate information (like commands and directories) but then we would lose additional information that this explanation bring and I don't think this is what we want. Note: Because I added the raw documents first in my pull request, you should be able to see clearly the modifications I made by going commit by commit. |
Hi @Sophie-Pages, I've had a quick look at the document. What I've seen so far looks excellent. Most importantly for our users, it's very complete, and combines and contextualises a lot of useful information about the underlying workings of what parts do and how they interact with the tool as a whole. I'll give it a full review as soon as possible, but for now I'll address this:
The contents of Parts lifecycle should be added to your new explanation page ( |
Background
We currently have four documents that provide key insights into the build lifecycle:
Request
On Snapcraft.io, we're missing a singular reference that covers the part lifecycle. That's the only appropriate place for these kinds of descriptions.
We ought to:
This work will eventually make its way into the Snapcraft ReadTheDocs site when page migration has progressed further.
These tasks will take a moderate amount of technical skill. We would appreciate anybody who is up for the challenge to give this a shot!
The text was updated successfully, but these errors were encountered: