Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib3<2 is impacting library compatibility #600

Closed
jocado opened this issue Jul 30, 2024 · 2 comments
Closed

urllib3<2 is impacting library compatibility #600

jocado opened this issue Jul 30, 2024 · 2 comments

Comments

@jocado
Copy link

jocado commented Jul 30, 2024

Hi,

Pinning urllib3<2 is causing some compatibility issues with including pylxd as a dependency in some projects. As it also forces requests< 2.32.0 that has some un-patched CVE.

Is there any chance it can be can be updated to urllib3>=2 ?

Thanks!

Cheers,
Just
@hamistao
Copy link
Contributor

hamistao commented Aug 5, 2024 •
edited
Loading

Pinning the requests< 2.32.0 is unfortunately necessary for the moment because of #579.

It is in our current plans for the next version to remove dependency on requests_unixsocket for this exact reason. This will enable us to update urllib3 as you suggested.

We should have more news on this topic soon, cheers.

@hamistao hamistao mentioned this issue Oct 1, 2024
Merged
simondeziel added a commit that referenced this issue Oct 1, 2024
@simondeziel
Remove requests_unixsocket (#604)
93b83d1 
This includes implementation to connect to a Unix socket without
`requests_unixsocket`. This allows us to remove this dependency along
with the version restrictions for `urllib3` and `requests`;

Fixes #583
#600
@simondeziel
Copy link
Member

Fixed by #604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simondeziel @jocado @hamistao