Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: undefined is not an object (evaluating 'r.name.firstName') #67

Open
SylvainBigonneau opened this issue Feb 13, 2022 · 0 comments

Comments

@SylvainBigonneau
Copy link
Contributor

Describe the bug
I have started getting the given error in my production telemetry when using SignInWithApple.authorize on iOS:

TypeError: undefined is not an object (evaluating 'r.name.firstName')

It seems to be related to this line, which seems to expect name to always be an object, and apparently it doesn't!

Maybe this is due to changes on Apple's side?

To Reproduce

SignInWithApple.authorize({
        clientId: this.appleClientId,
        redirectURI: `${process.env.BASE_URL}/signin`,
        scopes: "email",
        state: "12345",
        nonce: "nonce",
})

Expected behavior
Should probably have a little guard for name to be possibly undefined, such as:

givenName: res.user?.name?.firstName,

Smartphone (please complete the following information):

  • OS: iOS
  • Browser: Mobile Safari
  • Version: v1.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant