Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usePopup configuration #75

Open
philipp-schaerer-lambdait opened this issue Jun 21, 2022 · 4 comments
Open

Add usePopup configuration #75

philipp-schaerer-lambdait opened this issue Jun 21, 2022 · 4 comments

Comments

@philipp-schaerer-lambdait
Copy link

philipp-schaerer-lambdait commented Jun 21, 2022

If someone has also got the problem that the Apple-Sign-In needs to be triggered twice while using an iOs device in the web environment, then it is probably due to a blocked popup. The error popup_blocked_by_browser is being triggered.

It would be nice to be able to set the usePopup option to false:

apple-sign-in/src/web.ts

Lines 36 to 37 in 9828277

nonce: options.nonce ?? undefined,
usePopup: true,

There was already a pull request for this change:
#62

The issue should be reproduceable using the Private Mode in Safari.
Edit: not sure if changing it to non-popup behavior really fixes the issue, should be tested with multiple devices

@georgefam
Copy link

having same issue, getting popup_blocked_by_browser

I have verified on real device and also changed safari on iPhone to allow popup and still getting same error

@yllaw
Copy link

yllaw commented Sep 20, 2022

I am also having this issue.

We send our web link through instagram and we try to drive users to sign up using Apple. The embedded web browser via IG will throw popup_blocked_by_browser.

This error is damaging our onboarding flow.

@marclou
Copy link

marclou commented Jan 18, 2023

Same issue here

@AAmeriyan
Copy link

Same Here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants