From 1699781d6ad7ecc84463fff78cfa69d7c9b367f4 Mon Sep 17 00:00:00 2001 From: den Date: Tue, 6 Feb 2024 23:13:46 +0100 Subject: [PATCH] fix:replace name to eventName in logEvent definition --- README.md | 8 +++--- ios/Plugin.xcodeproj/project.pbxproj | 8 ++++++ ios/Plugin/Plugin.swift | 4 +-- ios/Podfile.lock | 43 ++++++++++++++++++++++++++++ package-lock.json | 3 ++ package.json | 2 +- src/definitions.ts | 2 +- src/web.ts | 2 +- 8 files changed, 63 insertions(+), 9 deletions(-) create mode 100644 ios/Podfile.lock diff --git a/README.md b/README.md index 2656e4b..08afe19 100644 --- a/README.md +++ b/README.md @@ -333,12 +333,12 @@ getProfile>(options: { fields: readonly string ### logEvent(...) ```typescript -logEvent(options: { name: string; }) => Promise +logEvent(options: { eventName: string; }) => Promise ``` -| Param | Type | -| ------------- | ------------------------------ | -| **`options`** | { name: string; } | +| Param | Type | +| ------------- | ----------------------------------- | +| **`options`** | { eventName: string; } | -------------------- diff --git a/ios/Plugin.xcodeproj/project.pbxproj b/ios/Plugin.xcodeproj/project.pbxproj index cf1aad8..0a23353 100644 --- a/ios/Plugin.xcodeproj/project.pbxproj +++ b/ios/Plugin.xcodeproj/project.pbxproj @@ -284,11 +284,19 @@ "${PODS_ROOT}/Target Support Files/Pods-PluginTests/Pods-PluginTests-frameworks.sh", "${BUILT_PRODUCTS_DIR}/Capacitor/Capacitor.framework", "${BUILT_PRODUCTS_DIR}/CapacitorCordova/Cordova.framework", + "${PODS_XCFRAMEWORKS_BUILD_DIR}/FBAEMKit/FBAEMKit.framework/FBAEMKit", + "${PODS_XCFRAMEWORKS_BUILD_DIR}/FBSDKCoreKit/FBSDKCoreKit.framework/FBSDKCoreKit", + "${PODS_XCFRAMEWORKS_BUILD_DIR}/FBSDKCoreKit_Basics/FBSDKCoreKit_Basics.framework/FBSDKCoreKit_Basics", + "${PODS_XCFRAMEWORKS_BUILD_DIR}/FBSDKLoginKit/FBSDKLoginKit.framework/FBSDKLoginKit", ); name = "[CP] Embed Pods Frameworks"; outputPaths = ( "${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Capacitor.framework", "${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Cordova.framework", + "${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/FBAEMKit.framework", + "${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/FBSDKCoreKit.framework", + "${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/FBSDKCoreKit_Basics.framework", + "${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/FBSDKLoginKit.framework", ); runOnlyForDeploymentPostprocessing = 0; shellPath = /bin/sh; diff --git a/ios/Plugin/Plugin.swift b/ios/Plugin/Plugin.swift index bf70115..e1ef374 100644 --- a/ios/Plugin/Plugin.swift +++ b/ios/Plugin/Plugin.swift @@ -123,8 +123,8 @@ public class FacebookLogin: CAPPlugin { } @objc func logEvent(_ call: CAPPluginCall) { - if let name = call.getString("name") { - AppEvents.shared.logEvent(AppEvents.Name(name)) + if let eventName = call.getString("eventName") { + AppEvents.shared.logEvent(AppEvents.Name(eventName)) } call.resolve() diff --git a/ios/Podfile.lock b/ios/Podfile.lock new file mode 100644 index 0000000..72872c2 --- /dev/null +++ b/ios/Podfile.lock @@ -0,0 +1,43 @@ +PODS: + - Capacitor (5.0.0): + - CapacitorCordova + - CapacitorCordova (5.0.0) + - FBAEMKit (16.1.3): + - FBSDKCoreKit_Basics (= 16.1.3) + - FBSDKCoreKit (16.1.3): + - FBAEMKit (= 16.1.3) + - FBSDKCoreKit_Basics (= 16.1.3) + - FBSDKCoreKit_Basics (16.1.3) + - FBSDKLoginKit (16.1.3): + - FBSDKCoreKit (= 16.1.3) + +DEPENDENCIES: + - "Capacitor (from `../node_modules/@capacitor/ios`)" + - "CapacitorCordova (from `../node_modules/@capacitor/ios`)" + - FBSDKCoreKit (= 16.1.3) + - FBSDKLoginKit (= 16.1.3) + +SPEC REPOS: + trunk: + - FBAEMKit + - FBSDKCoreKit + - FBSDKCoreKit_Basics + - FBSDKLoginKit + +EXTERNAL SOURCES: + Capacitor: + :path: "../node_modules/@capacitor/ios" + CapacitorCordova: + :path: "../node_modules/@capacitor/ios" + +SPEC CHECKSUMS: + Capacitor: b332cb737d447561e854039fb72195206685dce2 + CapacitorCordova: 4ea17670ee562680988a7ce9db68dee5160fe564 + FBAEMKit: af2972f39bb0f3f7c45998f435b007833c32ffb2 + FBSDKCoreKit: 19e2e18b3be578d7a51fed8fdd8c152bef0b9511 + FBSDKCoreKit_Basics: dd9826ce3c9fd9f8cdf8dbbd0ef0a53e6c0c9e7e + FBSDKLoginKit: c395c63a1a6cf4a8a1e6103fd94b8c46329ee81c + +PODFILE CHECKSUM: 84bd0ef43d21cc257916d7be16544e4f2fe7d24d + +COCOAPODS: 1.12.1 diff --git a/package-lock.json b/package-lock.json index bb05632..7fb7178 100644 --- a/package-lock.json +++ b/package-lock.json @@ -28,6 +28,9 @@ "rollup": "^2.48.0", "swiftlint": "^1.0.1", "typescript": "~4.1.5" + }, + "engines": { + "node": ">=16.0.0" } }, "node_modules/@babel/code-frame": { diff --git a/package.json b/package.json index 8c9bdcc..6112170 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@capacitor-community/facebook-login", - "version": "5.0.3", + "version": "5.0.4-beta", "description": "A native plugin for Facebook Login", "engines": { "node": ">=16.0.0" diff --git a/src/definitions.ts b/src/definitions.ts index 3bc616c..f55702a 100644 --- a/src/definitions.ts +++ b/src/definitions.ts @@ -28,7 +28,7 @@ export interface FacebookLoginPlugin { getProfile>(options: { fields: readonly string[]; }): Promise; - logEvent(options: { name: string }): Promise; + logEvent(options: { eventName: string }): Promise; setAutoLogAppEventsEnabled(options: { enabled: boolean }): Promise; setAdvertiserTrackingEnabled(options: { enabled: boolean }): Promise; setAdvertiserIDCollectionEnabled(options: { diff --git a/src/web.ts b/src/web.ts index 36fe512..9b3f1e8 100644 --- a/src/web.ts +++ b/src/web.ts @@ -41,7 +41,7 @@ declare interface Facebook { params: TParams, callback: (response: TResponse) => void, ): void; - logEvent(handle: (response: any) => void, options: { name: string }): void; + logEvent(handle: (response: any) => void, options: { eventName: string }): void; setAutoLogAppEventsEnabled( handle: (response: any) => void, options: { enabled: boolean },