Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: not correctly handling optional imageName #80

Closed
reinventit opened this issue Nov 6, 2023 · 0 comments · Fixed by #81
Closed

bug: not correctly handling optional imageName #80

reinventit opened this issue Nov 6, 2023 · 0 comments · Fixed by #81

Comments

@reinventit
Copy link
Contributor

Plugin version:
4.2.1

Platform(s):
iOS (16.4)

Current behavior:
If no imageName is given, then this results in errors (and not showing the gray overlay

Expected behavior:
No imageName (or empty one) should default to gray overlay on iOS

Steps to reproduce:
Provide no imageName in configuration, app switcher shows white view (and debugger gives errors because of missing image)

Related code:
Not working

if let imageName = config.imageName {

Working

if let imageName = config.imageName, !imageName.isEmpty {

Other information:

Capacitor doctor:

💊   Capacitor Doctor  💊 

Latest Dependencies:

  @capacitor/cli: 5.5.1
  @capacitor/core: 5.5.1
  @capacitor/android: 5.5.1
  @capacitor/ios: 5.5.1

Installed Dependencies:

  @capacitor/core: 5.5.1
  @capacitor/android: 5.5.1
  @capacitor/cli: 5.5.1
  @capacitor/ios: 5.5.1

[success] iOS looking great! 👌
[success] Android looking great! 👌
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant